Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/browser/resources/md_history/history.js

Issue 2088093004: Add a footer about other forms of history to the MD history page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_history/app.js ('k') | chrome/browser/resources/md_history/side_bar.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_history/history.js
diff --git a/chrome/browser/resources/md_history/history.js b/chrome/browser/resources/md_history/history.js
index a81338b4be58bb0d0c77b356e643670d0c62f1d9..8f248b966dfa747c29fc5efed33c3e0c95e7fdc3 100644
--- a/chrome/browser/resources/md_history/history.js
+++ b/chrome/browser/resources/md_history/history.js
@@ -47,8 +47,16 @@ function historyResult(info, results) {
*/
function showNotification(
hasSyncedResults, includeOtherFormsOfBrowsingHistory) {
- // TODO(msramek): Implement the joint notification about web history and other
- // forms of browsing history for the MD history page.
+ // TODO(msramek): |hasSyncedResults| was used in the old WebUI to show
+ // the message about other signed-in devices. This message does not exist
+ // in the MD history anymore, so the parameter is not needed. Remove it
+ // when WebUI is removed and this becomes the only client of
+ // BrowsingHistoryHandler.
+ var appElem = $('history-app');
+ waitForUpgrade(appElem).then(function() {
+ /** @type {HistoryAppElement} */(appElem)
+ .getSideBar().showFooter = includeOtherFormsOfBrowsingHistory;
+ });
}
/**
« no previous file with comments | « chrome/browser/resources/md_history/app.js ('k') | chrome/browser/resources/md_history/side_bar.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698