Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3383)

Unified Diff: chrome/browser/resources/md_history/side_bar.html

Issue 2088093004: Add a footer about other forms of history to the MD history page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/side_bar.html
diff --git a/chrome/browser/resources/md_history/side_bar.html b/chrome/browser/resources/md_history/side_bar.html
index 9468875d34d5b24a0c9c24e9c3ad5919d1b82a80..2b344d53da2d38154e6ed0f94aa945b6937dbc01 100644
--- a/chrome/browser/resources/md_history/side_bar.html
+++ b/chrome/browser/resources/md_history/side_bar.html
@@ -10,6 +10,7 @@
<style include="shared-style">
:host {
display: block;
+ height: 100%;
padding-top: 5px;
width: var(--side-bar-width);
}
@@ -40,7 +41,7 @@
}
paper-item {
- -webkit-padding-start: 25px;
+ -webkit-padding-start: 24px;
cursor: pointer;
font-size: 14px;
font-weight: 500;
@@ -55,6 +56,26 @@
-webkit-user-select: none;
color: #5a5a5a;
}
+
+ #footer {
+ /* This compensates the 120px by which app-drawer protrudes under
+ the viewport. */
Dan Beam 2016/07/12 02:05:57 I think you overthought what I meant by my last co
msramek 2016/07/12 13:56:36 Ah :) Done. ( Nevertheless, I wanted to explain t
+ bottom: 120px;
+ color: var(--paper-grey-600);
+ position: absolute;
+ width: var(--side-bar-width);
+ }
+
+ #footer-text {
+ -webkit-padding-end: 16px;
+ -webkit-padding-start: 24px;
+ margin: 24px 0;
+ }
+
+ #footer a {
+ color: var(--google-blue-700);
+ text-decoration: none;
+ }
</style>
<app-drawer id="drawer" tabindex="0" on-focus="onDrawerFocus_" swipe-open
@@ -75,6 +96,10 @@
<paper-item on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
$i18n{clearBrowsingData}
</paper-item>
+ <div id="footer" hidden="[[!showFooter]]">
+ <div class="separator"></div>
+ <div id="footer-text">$i18nRaw{sidebarFooter}</div>
+ </div>
</iron-selector>
</app-drawer>
</template>

Powered by Google App Engine
This is Rietveld 408576698