Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: chrome/browser/resources/md_history/side_bar.js

Issue 2088093004: Add a footer about other forms of history to the MD history page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 Polymer({ 5 Polymer({
6 is: 'history-side-bar', 6 is: 'history-side-bar',
7 7
8 properties: { 8 properties: {
9 selectedPage: { 9 selectedPage: {
10 type: String, 10 type: String,
11 notify: true 11 notify: true
12 }, 12 },
13
14 showFooter: {
15 type: Boolean,
16 value: false
calamity 2016/07/05 04:03:13 I think you can get away with showFooter: Boolean
msramek 2016/07/06 19:24:10 Done. Probably yes - the call setting this value w
17 }
13 }, 18 },
14 19
15 toggle: function() { 20 toggle: function() {
16 this.$.drawer.toggle(); 21 this.$.drawer.toggle();
17 }, 22 },
18 23
19 /** @private */ 24 /** @private */
20 onDrawerFocus_: function() { 25 onDrawerFocus_: function() {
21 // The desired behavior is for the app-drawer to focus the currently 26 // The desired behavior is for the app-drawer to focus the currently
22 // selected menu item on opening. However, it will always focus the first 27 // selected menu item on opening. However, it will always focus the first
23 // focusable child. Therefore, we set tabindex=0 on the app-drawer so that 28 // focusable child. Therefore, we set tabindex=0 on the app-drawer so that
24 // it will focus itself and then immediately delegate focus to the selected 29 // it will focus itself and then immediately delegate focus to the selected
25 // item in this listener. 30 // item in this listener.
26 this.$.menu.selectedItem.focus(); 31 this.$.menu.selectedItem.focus();
27 }, 32 },
28 33
29 /** @private */ 34 /** @private */
30 onSelectorActivate_: function() { 35 onSelectorActivate_: function() {
31 this.$.drawer.close(); 36 this.$.drawer.close();
32 }, 37 },
33 38
34 /** 39 /**
35 * Relocates the user to the clear browsing data section of the settings page. 40 * Relocates the user to the clear browsing data section of the settings page.
36 * @private 41 * @private
37 */ 42 */
38 onClearBrowsingDataTap_: function() { 43 onClearBrowsingDataTap_: function() {
39 window.location.href = 'chrome://settings/clearBrowserData'; 44 window.location.href = 'chrome://settings/clearBrowserData';
40 }, 45 },
41 }); 46 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698