Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: chrome/browser/resources/md_history/side_bar.html

Issue 2088093004: Add a footer about other forms of history to the MD history page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/polymer/v1_0/app-layout/app-drawer/a pp-drawer.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/app-layout/app-drawer/a pp-drawer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-sele ctor.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-selector/iron-sele ctor.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html "> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-styles/color.html ">
6 <link rel="import" href="chrome://history/shared_style.html"> 6 <link rel="import" href="chrome://history/shared_style.html">
7 7
8 <dom-module id="history-side-bar"> 8 <dom-module id="history-side-bar">
9 <template> 9 <template>
10 <style include="shared-style"> 10 <style include="shared-style">
11 :host { 11 :host {
12 display: block; 12 display: block;
13 height: 100%;
13 padding-top: 5px; 14 padding-top: 5px;
14 width: var(--side-bar-width); 15 width: var(--side-bar-width);
15 } 16 }
16 17
17 #drawer-header { 18 #drawer-header {
18 align-items: center; 19 align-items: center;
19 border-bottom: 1px solid rgba(0, 0, 0, 0.08); 20 border-bottom: 1px solid rgba(0, 0, 0, 0.08);
20 display: flex; 21 display: flex;
21 height: var(--toolbar-height); 22 height: var(--toolbar-height);
22 margin-bottom: 5px; 23 margin-bottom: 5px;
(...skipping 10 matching lines...) Expand all
33 background-color: rgba(0, 0, 0, 0.08); 34 background-color: rgba(0, 0, 0, 0.08);
34 height: 1px; 35 height: 1px;
35 margin: 8px 0; 36 margin: 8px 0;
36 } 37 }
37 38
38 #clear-browsing-data { 39 #clear-browsing-data {
39 text-transform: uppercase; 40 text-transform: uppercase;
40 } 41 }
41 42
42 paper-item { 43 paper-item {
43 -webkit-padding-start: 25px; 44 -webkit-padding-start: 24px;
44 cursor: pointer; 45 cursor: pointer;
45 font-size: 14px; 46 font-size: 14px;
46 font-weight: 500; 47 font-weight: 500;
47 } 48 }
48 49
49 paper-item.iron-selected { 50 paper-item.iron-selected {
50 color: var(--google-blue-500); 51 color: var(--google-blue-500);
51 font-weight: 500; 52 font-weight: 500;
52 } 53 }
53 54
54 iron-selector { 55 iron-selector {
55 -webkit-user-select: none; 56 -webkit-user-select: none;
56 color: #5a5a5a; 57 color: #5a5a5a;
57 } 58 }
59
60 #footer {
61 /* This compensates the 120px by which app-banner protrudes under
calamity 2016/07/05 04:03:13 by which app-"drawer"?
msramek 2016/07/06 19:24:10 Done. Force of habit :)
62 the viewport. */
Dan Beam 2016/07/01 15:38:27 /* This compensates the 120px by which app-banner
msramek 2016/07/06 19:24:10 app-drawer, sorry for the confusion :) Specifical
63 bottom: 120px;
64 color: var(--paper-grey-600);
65 position: absolute;
66 width: var(--side-bar-width);
67 }
68
69 #footer-text {
70 -webkit-padding-end: 16px;
71 -webkit-padding-start: 24px;
72 margin: 24px 0;
73 }
74
75 #footer a {
76 color: var(--google-blue-700);
77 text-decoration: none;
78 }
58 </style> 79 </style>
59 80
60 <app-drawer id="drawer" tabindex="0" on-focus="onDrawerFocus_" swipe-open 81 <app-drawer id="drawer" tabindex="0" on-focus="onDrawerFocus_" swipe-open
61 align="start"> 82 align="start">
62 <div id="drawer-header"> 83 <div id="drawer-header">
63 <h1>$i18n{title}</h1> 84 <h1>$i18n{title}</h1>
64 </div> 85 </div>
65 <iron-selector id="menu" selected="{{selectedPage}}" 86 <iron-selector id="menu" selected="{{selectedPage}}"
66 selectable=".page-item" attr-for-selected="view-id" 87 selectable=".page-item" attr-for-selected="view-id"
67 on-iron-activate="onSelectorActivate_"> 88 on-iron-activate="onSelectorActivate_">
68 <paper-item view-id="history-list" class="page-item"> 89 <paper-item view-id="history-list" class="page-item">
69 $i18n{historyMenuItem} 90 $i18n{historyMenuItem}
70 </paper-item> 91 </paper-item>
71 <paper-item view-id="history-synced-device-manager" class="page-item"> 92 <paper-item view-id="history-synced-device-manager" class="page-item">
72 $i18n{openTabsMenuItem} 93 $i18n{openTabsMenuItem}
73 </paper-item> 94 </paper-item>
74 <div class="separator"></div> 95 <div class="separator"></div>
75 <paper-item on-tap="onClearBrowsingDataTap_" id="clear-browsing-data"> 96 <paper-item on-tap="onClearBrowsingDataTap_" id="clear-browsing-data">
76 $i18n{clearBrowsingData} 97 $i18n{clearBrowsingData}
77 </paper-item> 98 </paper-item>
99 <div id="footer" hidden="[[!showFooter]]">
100 <div class="separator"></div>
101 <div id="footer-text">$i18nRaw{footer}</div>
calamity 2016/07/05 04:03:13 nit: sidebarFooter perhaps?
msramek 2016/07/06 19:24:10 Done.
102 </div>
78 </iron-selector> 103 </iron-selector>
79 </app-drawer> 104 </app-drawer>
80 </template> 105 </template>
81 <script src="chrome://history/side_bar.js"></script> 106 <script src="chrome://history/side_bar.js"></script>
82 </dom-module> 107 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698