Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2088073002: Roll internal Google Play Services (Chromium part) (Closed)

Created:
4 years, 6 months ago by paulmiller
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll internal Google Play Services (Chromium part) BUG=613768 TBR=jbudorick@chromium.org,agrieve@chromium.org,mariakhomenko@chromium.org NOTRY=true (skipping trybots because previous, identical patch passed CQ, and because this is needed to fix the tree) Committed: https://crrev.com/c3199997a359e45fee3526111b4a5d25d8e6ea1b Cr-Commit-Position: refs/heads/master@{#401419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -24 lines) Patch
M build/android/play_services/preprocess.py View 3 chunks +34 lines, -16 lines 0 comments Download
M build/config/android/internal_rules.gni View 4 chunks +16 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
paulmiller
On 2016/06/21 22:23:46, paulmiller wrote: > mailto:paulmiller@chromium.org changed reviewers: > + mailto:agrieve@chromium.org, mailto:jbudorick@chromium.org, mailto:mariakhomenko@chromium.org This ...
4 years, 6 months ago (2016-06-21 22:26:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088073002/1
4 years, 6 months ago (2016-06-22 17:59:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/243493)
4 years, 6 months ago (2016-06-22 21:19:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088073002/1
4 years, 6 months ago (2016-06-22 21:39:50 UTC) #10
sgurun-gerrit only
On 2016/06/22 21:39:50, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 6 months ago (2016-06-22 21:45:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2088073002/1
4 years, 6 months ago (2016-06-22 21:46:23 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 21:52:23 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c3199997a359e45fee3526111b4a5d25d8e6ea1b Cr-Commit-Position: refs/heads/master@{#401419}
4 years, 6 months ago (2016-06-22 21:54:01 UTC) #19
paulmiller
4 years, 6 months ago (2016-06-22 23:16:58 UTC) #20
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2095473002/ by paulmiller@chromium.org.

The reason for reverting is: broke.

Powered by Google App Engine
This is Rietveld 408576698