Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Side by Side Diff: src/code-stubs-hydrogen.cc

Issue 2087963004: Revert of [Crankshaft] Always check for stubs marked to not require an eager frame. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/crankshaft/lithium.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include "src/bailout-reason.h" 7 #include "src/bailout-reason.h"
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/field-index.h" 10 #include "src/field-index.h"
(...skipping 2043 matching lines...) Expand 10 before | Expand all | Expand 10 after
2054 } 2054 }
2055 2055
2056 2056
2057 template<> 2057 template<>
2058 HValue* CodeStubGraphBuilder<RegExpConstructResultStub>::BuildCodeStub() { 2058 HValue* CodeStubGraphBuilder<RegExpConstructResultStub>::BuildCodeStub() {
2059 // Determine the parameters. 2059 // Determine the parameters.
2060 HValue* length = GetParameter(RegExpConstructResultStub::kLength); 2060 HValue* length = GetParameter(RegExpConstructResultStub::kLength);
2061 HValue* index = GetParameter(RegExpConstructResultStub::kIndex); 2061 HValue* index = GetParameter(RegExpConstructResultStub::kIndex);
2062 HValue* input = GetParameter(RegExpConstructResultStub::kInput); 2062 HValue* input = GetParameter(RegExpConstructResultStub::kInput);
2063 2063
2064 // TODO(turbofan): This codestub has regressed to need a frame on ia32 at some
2065 // point and wasn't caught since it wasn't built in the snapshot. We should
2066 // probably just replace with a TurboFan stub rather than fixing it.
2067 #if !V8_TARGET_ARCH_IA32
2068 info()->MarkMustNotHaveEagerFrame(); 2064 info()->MarkMustNotHaveEagerFrame();
2069 #endif
2070 2065
2071 return BuildRegExpConstructResult(length, index, input); 2066 return BuildRegExpConstructResult(length, index, input);
2072 } 2067 }
2073 2068
2074 2069
2075 Handle<Code> RegExpConstructResultStub::GenerateCode() { 2070 Handle<Code> RegExpConstructResultStub::GenerateCode() {
2076 return DoGenerateCode(this); 2071 return DoGenerateCode(this);
2077 } 2072 }
2078 2073
2079 2074
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
2317 return Pop(); 2312 return Pop();
2318 } 2313 }
2319 2314
2320 2315
2321 Handle<Code> KeyedLoadGenericStub::GenerateCode() { 2316 Handle<Code> KeyedLoadGenericStub::GenerateCode() {
2322 return DoGenerateCode(this); 2317 return DoGenerateCode(this);
2323 } 2318 }
2324 2319
2325 } // namespace internal 2320 } // namespace internal
2326 } // namespace v8 2321 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/crankshaft/lithium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698