cc: Stop creating unused 0 property tree nodes other than transform

cc/trees/layer_tree_host_common_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host_common.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 9652 matching lines @@
                                gfx::PointF(), gfx::Size(30, 30), true, false,
                                true);
   SetLayerPropertiesForTesting(clip_child, identity_matrix, gfx::Point3F(),
                                gfx::PointF(), gfx::Size(30, 30), true, false,
                                false);
   ExecuteCalculateDrawProperties(root);
 
   EXPECT_EQ(gfx::Rect(-10, -10, 30, 30), render_surface2->clip_rect());
   // A clip node is created for every render surface and for layers that have
   // local clip. So, here it should be craeted for every layer.
-  EXPECT_EQ(root->layer_tree_impl()->property_trees()->clip_tree.size(), 5u);
+  EXPECT_EQ(root->layer_tree_impl()->property_trees()->clip_tree.size(), 4u);
 }
 
 TEST_F(LayerTreeHostCommonTest, MaskLayerDrawProperties) {
   // Tests that a mask layer's draw properties are computed correctly.
   LayerImpl* root = root_layer();
   LayerImpl* child = AddChild<LayerImpl>(root);
   child->test_properties()->SetMaskLayer(
       LayerImpl::Create(root->layer_tree_impl(), 100));
   LayerImpl* mask = child->test_properties()->mask_layer;
 
@@ skipping 401 matching lines @@
   // +----parent3(3)
   // +------child7(7)[scrollable]
   // +------child8(8)[scroll_parent=7]
   // +--------grand_child11(11)[scrollable]
   // +----parent4(4)
   // +------child9(9)
   // +--------grand_child12(12)
   // +----parent5(5)[contains_non_fast_scrollable_region]
   //
   // Expected scroll tree topology:
-  // +property_tree_root---owner:-1
-  // +--root---owner:1, id:1
-  // +----node---owner:2, id:2
-  // +------node---owner:6, id:3
-  // +----node---owner:7, id:4
-  // +------node---owner:11, id:5
-  // +----node---owner:5, id:6
+  // +root---owner:1, id:0
+  // +--node---owner:2, id:1
+  // +----node---owner:6, id:2
+  // +--node---owner:7, id:3
+  // +----node---owner:11, id:4
+  // +--node---owner:5, id:5
   //
   // Extra check:
   //   scroll_tree_index() of:
-  //     grand_child10:3
-  //     parent3:1
-  //     child8:4
-  //     parent4:1
-  //     child9:1
-  //     grand_child12:1
+  //     grand_child10:2
+  //     parent3:0
+  //     child8:3
+  //     parent4:0
+  //     child9:0
+  //     grand_child12:0
   scoped_refptr<Layer> root1 = Layer::Create();
   scoped_refptr<Layer> page_scale_layer = Layer::Create();
   scoped_refptr<Layer> parent2 = Layer::Create();
   scoped_refptr<Layer> parent3 = Layer::Create();
   scoped_refptr<Layer> parent4 = Layer::Create();
   scoped_refptr<Layer> parent5 = Layer::Create();
   scoped_refptr<Layer> child6 = Layer::Create();
   scoped_refptr<Layer> child7 = Layer::Create();
   scoped_refptr<Layer> child8 = Layer::Create();
   scoped_refptr<Layer> child9 = Layer::Create();
@@ skipping 29 matching lines @@
 
   child8->SetScrollParent(child7.get());
   grand_child11->SetScrollClipLayerId(parent3->id());
 
   parent5->SetNonFastScrollableRegion(gfx::Rect(0, 0, 50, 50));
   parent5->SetBounds(gfx::Size(10, 10));
 
   host()->RegisterViewportLayers(NULL, page_scale_layer, parent2, NULL);
   ExecuteCalculateDrawPropertiesWithPropertyTrees(root1.get());
 
-  const int kInvalidPropertyTreeNodeId = -1;
-  const int kRootPropertyTreeNodeId = 0;
-
   // Property tree root
   ScrollTree& scroll_tree = host()->property_trees()->scroll_tree;
   PropertyTrees property_trees;
   property_trees.is_main_thread = true;
   property_trees.is_active = false;
   ScrollTree& expected_scroll_tree = property_trees.scroll_tree;
-  ScrollNode* property_tree_root = expected_scroll_tree.Node(0);
-  property_tree_root->id = kRootPropertyTreeNodeId;
-  property_tree_root->parent_id = kInvalidPropertyTreeNodeId;
-  property_tree_root->owner_id = kInvalidPropertyTreeNodeId;
-  property_tree_root->data.scrollable = false;
-  property_tree_root->data.main_thread_scrolling_reasons =
-      MainThreadScrollingReason::kNotScrollingOnMain;
-  property_tree_root->data.contains_non_fast_scrollable_region = false;
-  property_tree_root->data.transform_id = kRootPropertyTreeNodeId;
 
   // The node owned by root1
   ScrollNode scroll_root1;
-  scroll_root1.id = 1;
+  scroll_root1.id = 0;
   scroll_root1.owner_id = root1->id();
   scroll_root1.data.user_scrollable_horizontal = true;
   scroll_root1.data.user_scrollable_vertical = true;
   scroll_root1.data.transform_id = root1->transform_tree_index();
-  expected_scroll_tree.Insert(scroll_root1, 0);
+  expected_scroll_tree.Insert(scroll_root1, -1);
 
   // The node owned by parent2
   ScrollNode scroll_parent2;
-  scroll_parent2.id = 2;
+  scroll_parent2.id = 1;
   scroll_parent2.owner_id = parent2->id();
   scroll_parent2.data.scrollable = true;
   scroll_parent2.data.main_thread_scrolling_reasons =
       parent2->main_thread_scrolling_reasons();
   scroll_parent2.data.scroll_clip_layer_bounds = root1->bounds();
   scroll_parent2.data.bounds = parent2->bounds();
   scroll_parent2.data.max_scroll_offset_affected_by_page_scale = true;
   scroll_parent2.data.is_inner_viewport_scroll_layer = true;
   scroll_parent2.data.user_scrollable_horizontal = true;
   scroll_parent2.data.user_scrollable_vertical = true;
   scroll_parent2.data.transform_id = parent2->transform_tree_index();
-  expected_scroll_tree.Insert(scroll_parent2, 1);
+  expected_scroll_tree.Insert(scroll_parent2, 0);
 
   // The node owned by child6
   ScrollNode scroll_child6;
-  scroll_child6.id = 3;
+  scroll_child6.id = 2;
   scroll_child6.owner_id = child6->id();
   scroll_child6.data.main_thread_scrolling_reasons =
       child6->main_thread_scrolling_reasons();
   scroll_child6.data.should_flatten = true;
   scroll_child6.data.user_scrollable_horizontal = true;
   scroll_child6.data.user_scrollable_vertical = true;
   scroll_child6.data.transform_id = child6->transform_tree_index();
-  expected_scroll_tree.Insert(scroll_child6, 2);
+  expected_scroll_tree.Insert(scroll_child6, 1);
 
   // The node owned by child7, child7 also owns a transform node
   ScrollNode scroll_child7;
-  scroll_child7.id = 4;
+  scroll_child7.id = 3;
   scroll_child7.owner_id = child7->id();
   scroll_child7.data.scrollable = true;
   scroll_child7.data.scroll_clip_layer_bounds = parent3->bounds();
   scroll_child7.data.bounds = child7->bounds();
   scroll_child7.data.user_scrollable_horizontal = true;
   scroll_child7.data.user_scrollable_vertical = true;
   scroll_child7.data.transform_id = child7->transform_tree_index();
-  expected_scroll_tree.Insert(scroll_child7, 1);
+  expected_scroll_tree.Insert(scroll_child7, 0);
 
   // The node owned by grand_child11, grand_child11 also owns a transform node
   ScrollNode scroll_grand_child11;
-  scroll_grand_child11.id = 5;
+  scroll_grand_child11.id = 4;
   scroll_grand_child11.owner_id = grand_child11->id();
   scroll_grand_child11.data.scrollable = true;
   scroll_grand_child11.data.user_scrollable_horizontal = true;
   scroll_grand_child11.data.user_scrollable_vertical = true;
   scroll_grand_child11.data.transform_id =
       grand_child11->transform_tree_index();
-  expected_scroll_tree.Insert(scroll_grand_child11, 4);
+  expected_scroll_tree.Insert(scroll_grand_child11, 3);
 
   // The node owned by parent5
   ScrollNode scroll_parent5;
-  scroll_parent5.id = 8;
+  scroll_parent5.id = 5;
   scroll_parent5.owner_id = parent5->id();
   scroll_parent5.data.contains_non_fast_scrollable_region = true;
   scroll_parent5.data.bounds = gfx::Size(10, 10);
   scroll_parent5.data.should_flatten = true;
   scroll_parent5.data.user_scrollable_horizontal = true;
   scroll_parent5.data.user_scrollable_vertical = true;
   scroll_parent5.data.transform_id = parent5->transform_tree_index();
-  expected_scroll_tree.Insert(scroll_parent5, 1);
+  expected_scroll_tree.Insert(scroll_parent5, 0);
 
   expected_scroll_tree.SetScrollOffset(parent2->id(), gfx::ScrollOffset(0, 0));
   expected_scroll_tree.SetScrollOffset(child7->id(), gfx::ScrollOffset(0, 0));
   expected_scroll_tree.SetScrollOffset(grand_child11->id(),
                                        gfx::ScrollOffset(0, 0));
   expected_scroll_tree.set_needs_update(false);
 
   EXPECT_EQ(expected_scroll_tree, scroll_tree);
 
   // Check other layers' scroll_tree_index
   EXPECT_EQ(scroll_root1.id, page_scale_layer->scroll_tree_index());
   EXPECT_EQ(scroll_child6.id, grand_child10->scroll_tree_index());
   EXPECT_EQ(scroll_root1.id, parent3->scroll_tree_index());
   EXPECT_EQ(scroll_child7.id, child8->scroll_tree_index());
   EXPECT_EQ(scroll_root1.id, parent4->scroll_tree_index());
   EXPECT_EQ(scroll_root1.id, child9->scroll_tree_index());
   EXPECT_EQ(scroll_root1.id, grand_child12->scroll_tree_index());
 }
 
 }  // namespace
 }  // namespace cc