third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h - Issue 2087953004: Switch v8 inspector to stl collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

Issue 2087953004: Switch v8 inspector to stl collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually remove a value from the list Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

index bf90eb241dafaf389c852fec8ae7c3d13dbfd3a8..b8d1641b53c962532450393079ff71633f1c8542 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InspectorSessionImpl.h

@@ -6,7 +6,6 @@

#define V8InspectorSessionImpl_h

#include "platform/inspector_protocol/Allocator.h"

-#include "platform/inspector_protocol/Collections.h"

#include "platform/inspector_protocol/DispatcherBase.h"

#include "platform/inspector_protocol/Platform.h"

#include "platform/inspector_protocol/String16.h"

@@ -16,6 +15,8 @@

#include <v8.h>

+#include <vector>

namespace blink {

class InjectedScript;

@@ -88,7 +89,7 @@ private:

std::unique_ptr<V8DebuggerAgentImpl> m_debuggerAgent;

std::unique_ptr<V8HeapProfilerAgentImpl> m_heapProfilerAgent;

std::unique_ptr<V8ProfilerAgentImpl> m_profilerAgent;

- protocol::Vector<std::unique_ptr<V8InspectorSession::Inspectable>> m_inspectedObjects;

+ std::vector<std::unique_ptr<V8InspectorSession::Inspectable>> m_inspectedObjects;

};

} // namespace blink