third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h - Issue 2087953004: Switch v8 inspector to stl collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

Issue 2087953004: Switch v8 inspector to stl collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually remove a value from the list Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

index 1c94d240aa91de2b9e781a17d156fb86b744c9b5..0b9d4e2a5096f12849ad72f8c292aae32427aec4 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

@@ -31,7 +31,6 @@

#ifndef V8FunctionCall_h

#define V8FunctionCall_h

-#include "platform/inspector_protocol/Collections.h"

#include "platform/inspector_protocol/String16.h"

#include <v8.h>

@@ -58,7 +57,7 @@ public:

protected:

V8DebuggerImpl* m_debugger;

v8::Local<v8::Context> m_context;

- protocol::Vector<v8::Local<v8::Value>> m_arguments;

+ std::vector<v8::Local<v8::Value>> m_arguments;

v8::Local<v8::String> m_name;

v8::Local<v8::Value> m_value;

};