third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h - Issue 2087953004: Switch v8 inspector to stl collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

Issue 2087953004: Switch v8 inspector to stl collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually remove a value from the list Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/Values.h ('K') | « third_party/WebKit/Source/platform/inspector_protocol/Values.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

index 63d2a30f3c316523063443afbdc766716677b5d2..c8082fe95edd61f14b0134bac734d6119342e510 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptNative.h

@@ -10,6 +10,8 @@

#include "platform/inspector_protocol/String16.h"

#include <v8.h>

+#include <vector>

namespace blink {

class InjectedScriptNative final {

@@ -35,7 +37,7 @@ private:

protocol::HashMap<int, std::unique_ptr<v8::Global<v8::Value>>> m_idToWrappedObject;

typedef protocol::HashMap<int, String16> IdToObjectGroupName;

IdToObjectGroupName m_idToObjectGroupName;

- typedef protocol::HashMap<String16, protocol::Vector<int>> NameToObjectGroup;

+ typedef protocol::HashMap<String16, std::vector<int>> NameToObjectGroup;

NameToObjectGroup m_nameToObjectGroup;

};