third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template - Issue 2087953004: Switch v8 inspector to stl collections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

Issue 2087953004: Switch v8 inspector to stl collections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Actually remove a value from the list Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/Values.h » ('j') | third_party/WebKit/Source/platform/inspector_protocol/Values.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

index 1aeef458f8d4bafaddc73094808112a73eb5b5c0..909fea4e71a7ff277ec21b061f6d1d36941ee930 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_cpp.template

@@ -140,7 +140,7 @@ public:

{% for command in domain.commands %}

{% if "redirect" in command %}{% continue %}{% endif %}

{% if "handlers" in command and not ("renderer" in command["handlers"]) %}{% continue %}{% endif %}

- m_dispatchMap.set("{{domain.domain}}.{{command.name}}", &DispatcherImpl::{{command.name}});

+ m_dispatchMap["{{domain.domain}}.{{command.name}}"] = &DispatcherImpl::{{command.name}};

{% endfor %}

}

~DispatcherImpl() override { }

@@ -169,7 +169,7 @@ void DispatcherImpl::dispatch(int callId, const String16& method, std::unique_pt

}

protocol::ErrorSupport errors;

- ((*this).*(*it->second))(callId, std::move(messageObject), &errors);

+ (this->*(it->second))(callId, std::move(messageObject), &errors);

}

{% for command in domain.commands %}