Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2087953003: Update `@factory` to allow for statics and nulls. (Closed)

Created:
4 years, 6 months ago by pquitslund
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M pkg/meta/CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/meta/lib/meta.dart View 1 chunk +6 lines, -8 lines 2 comments Download
M pkg/meta/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 6 months ago (2016-06-21 22:24:42 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2087953003/diff/1/pkg/meta/lib/meta.dart File pkg/meta/lib/meta.dart (right): https://codereview.chromium.org/2087953003/diff/1/pkg/meta/lib/meta.dart#newcode29 pkg/meta/lib/meta.dart:29: /// can return anything other than a newly ...
4 years, 6 months ago (2016-06-21 22:28:15 UTC) #3
pquitslund
Committed patchset #1 (id:1) manually as 1ec53e449c2f1bf8bcdfb8028425870be0d05e90 (presubmit successful).
4 years, 6 months ago (2016-06-21 22:33:17 UTC) #5
pquitslund
4 years, 6 months ago (2016-06-21 22:33:36 UTC) #6
Message was sent while issue was closed. 
Super.  Thanks!

https://codereview.chromium.org/2087953003/diff/1/pkg/meta/lib/meta.dart
File pkg/meta/lib/meta.dart (right):

https://codereview.chromium.org/2087953003/diff/1/pkg/meta/lib/meta.dart#newc...
pkg/meta/lib/meta.dart:29: ///   can return anything other than a newly
allocated object or null.
On 2016/06/21 22:28:15, Brian Wilkerson wrote:
> "null" --> "`null`"
> 
> Also, restore a variation on the initial restriction:
> 
> * the annotation is associated with anything other than a method,

Done.

Powered by Google App Engine
This is Rietveld 408576698