Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2087933006: V8: Fix gyp flag comparison for windows. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Fix gyp flag comparison for windows. The output for windows is different. This adjusts the regular expression to reflect that. BUG=616035 TBR=vogelheim@chromium.org, kjellander@chromium.org, tandrii@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/build/+/aa1287286c58cb360ac84dc1f254ee88d9f3352d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M scripts/slave/recipe_modules/v8/api.py View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
PTAL. The comparison silently ignores windows at the moment (because it doesn't match it thinks ...
4 years, 6 months ago (2016-06-22 14:43:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087933006/1
4 years, 6 months ago (2016-06-22 14:55:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/aa1287286c58cb360ac84dc1f254ee88d9f3352d
4 years, 6 months ago (2016-06-22 14:59:31 UTC) #7
tandrii(chromium)
4 years, 6 months ago (2016-06-22 15:51:29 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698