Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 208793004: Trace more methods under HTMLDocumentParser::insert (Closed)

Created:
6 years, 9 months ago by eseidel
Modified:
6 years, 8 months ago
Reviewers:
nduca, abarth-chromium
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Trace more methods under HTMLDocumentParser::insert This should help us better understand long HTMLDocumentParser::insert blocks when we encounter them on traces. BUG=356292 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170464

Patch Set 1 #

Patch Set 2 : Use "source_length" instead of just "length" as an argument name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
eseidel
Ready for review.
6 years, 9 months ago (2014-03-25 18:46:30 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-25 21:04:02 UTC) #2
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-25 21:08:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/208793004/30001
6 years, 9 months ago (2014-03-25 21:08:57 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 22:14:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 22:14:24 UTC) #6
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 9 months ago (2014-03-28 20:36:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/208793004/30001
6 years, 9 months ago (2014-03-28 20:36:42 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 21:22:42 UTC) #9
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-28 21:22:42 UTC) #10
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 8 months ago (2014-03-31 17:07:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eseidel@chromium.org/208793004/30001
6 years, 8 months ago (2014-03-31 17:08:02 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 17:08:57 UTC) #13
Message was sent while issue was closed. 
Change committed as 170464

Powered by Google App Engine
This is Rietveld 408576698