Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2087913002: Avoid changing select element via synthesized keydown from ChromeVox test (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
David Tseng, dtapuska
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid changing select element via synthesized keydown from ChromeVox test BUG=520519 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/6f41102f11e37521b65031a19600375f4319cda8 Cr-Commit-Position: refs/heads/master@{#401295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_e2e_test_base.js View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dmazzoni
4 years, 6 months ago (2016-06-21 19:56:40 UTC) #3
dtapuska
On 2016/06/21 19:56:40, dmazzoni wrote: lgtm
4 years, 6 months ago (2016-06-21 19:58:20 UTC) #4
dtapuska
On 2016/06/21 19:58:20, dtapuska wrote: > On 2016/06/21 19:56:40, dmazzoni wrote: > > lgtm dtseng@ ...
4 years, 6 months ago (2016-06-22 14:58:09 UTC) #5
David Tseng
lgtm
4 years, 6 months ago (2016-06-22 15:58:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087913002/1
4 years, 6 months ago (2016-06-22 15:58:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 16:05:33 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 16:08:18 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f41102f11e37521b65031a19600375f4319cda8
Cr-Commit-Position: refs/heads/master@{#401295}

Powered by Google App Engine
This is Rietveld 408576698