Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2087893004: VM: AOT optimizer does not need to check for overrides if receiver's cid is known. (Closed)

Created:
4 years, 6 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: AOT optimizer does not need to check for overrides if receiver's cid is known. Class ids inferred by the type propagator are always concrete: value is guaranteed to be an instance of inferred class and can't be an instance of a subclass. R=fschneider@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/81451be4211717832274b60d5492b6db232f695e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -29 lines) Patch
M runtime/vm/aot_optimizer.cc View 2 chunks +15 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Vyacheslav Egorov (Google)
4 years, 6 months ago (2016-06-22 17:55:04 UTC) #1
Florian Schneider
LGTM
4 years, 6 months ago (2016-06-22 17:58:03 UTC) #2
Vyacheslav Egorov (Google)
4 years, 6 months ago (2016-06-22 18:09:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
81451be4211717832274b60d5492b6db232f695e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698