chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java - Issue 2087893003: Migrate TabPersistentStore to one shared directory for multi-instance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

Issue 2087893003: Migrate TabPersistentStore to one shared directory for multi-instance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoNotificationService.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

index a4072a5c863abb831dc45fd02c82397f7796c6d3..908eab71cfb812f98423695686ece83ceef1f835 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java

@@ -321,10 +321,8 @@ public class TabContentManager {

// BUG: We support multiple tab model selectors, and they all share the same thumbnail

// directory. This cleanup code checks only the current model selector to see if the

- // thumbnails are no longer used. It should instead:

- // a) consult with *all* tab model selectors (which may not even be in memory)

- // b) use separate thumbnail directories for each tab model (perhaps using hardlink to

- // eliminate disk overhead)

+ // thumbnails are no longer used. It should instead consult with *all* tab model selectors

+ // (which may not even be in memory).

new AsyncTask<Void, Void, String[]>() {

@Override

protected String[] doInBackground(Void... voids) {