[cocoa] increase tab strip contrast in "Increase Contrast" mode

[cocoa] increase tab strip contrast in "Increase Contrast" mode

With this change, when the "Increase Contrast" accessibility option is enabled:
1) The tab strip's bottom border is drawn in black instead of grey
2) Tab edges are drawn in black instead of grey
3) The active tab's title is bolded

BUG=619922
Committed: https://crrev.com/0877d7c2bf39b6179782438f55966754be8ef2a5
Cr-Commit-Position: refs/heads/master@{#401648}

[Elly Fong-Jones, 2016-06-21 17:56:03]

Description was changed from

==========
[cocoa] increase tab strip contrast in "Increase Contrast" mode

With this change, when the "Increase Contrast" accessibility option is enabled:
1) The tab strip's bottom border is drawn in black instead of grey
2) Tab edges are drawn in black instead of grey
3) The active tab's title is bolded

BUG=619922
==========

to

==========
[cocoa] increase tab strip contrast in "Increase Contrast" mode

With this change, when the "Increase Contrast" accessibility option is enabled:
1) The tab strip's bottom border is drawn in black instead of grey
2) Tab edges are drawn in black instead of grey
3) The active tab's title is bolded

BUG=619922
==========

[Elly Fong-Jones, 2016-06-21 17:56:03]

ellyjones@chromium.org changed reviewers:
+ mark@chromium.org

[Elly Fong-Jones, 2016-06-21 17:56:10]

mark: ptal? :)

[Mark Mentovai, 2016-06-21 19:58:54]

LGTM

If this code normally does do OS version checks instead of
respondsToSelector/non-null symbol checks, then feel free to ignore those
comments.

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_service_mac.mm (right):

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_mac.mm:418: if
(base::mac::IsOSYosemiteOrLater())
Wouldn’t our usual style be to use -respondsToSelector instead of this?

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (right):

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:70: extern NSString* const _Nonnull
NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification;
Wrap the long name to a hanging-indent line of its own.

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:202: if
(base::mac::IsOSYosemiteOrLater()) {
Here (and in -dealloc) too, would it be more our style to use

  if (NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification)

[Elly Fong-Jones, 2016-06-21 20:25:36]

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/themes/theme...
File chrome/browser/themes/theme_service_mac.mm (right):

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/themes/theme...
chrome/browser/themes/theme_service_mac.mm:418: if
(base::mac::IsOSYosemiteOrLater())
On 2016/06/21 19:58:54, Mark Mentovai wrote:
> Wouldn’t our usual style be to use -respondsToSelector instead of this?

Done.

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/ui/cocoa/tab...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (right):

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:70: extern NSString* const _Nonnull
NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification;
On 2016/06/21 19:58:54, Mark Mentovai wrote:
> Wrap the long name to a hanging-indent line of its own.

Done.

https://codereview.chromium.org/2087893002/diff/1/chrome/browser/ui/cocoa/tab...
chrome/browser/ui/cocoa/tabs/tab_view.mm:202: if
(base::mac::IsOSYosemiteOrLater()) {
On 2016/06/21 19:58:54, Mark Mentovai wrote:
> Here (and in -dealloc) too, would it be more our style to use
> 
>   if (NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification)

Done.

[Elly Fong-Jones, 2016-06-21 20:26:01]

ellyjones@chromium.org changed reviewers:
+ thakis@chromium.org

[Elly Fong-Jones, 2016-06-21 20:26:12]

thakis: ptal as ui owner? :)

[Nico, 2016-06-21 20:40:22]

lgtm!

https://codereview.chromium.org/2087893002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/tabs/tab_view.mm (right):

https://codereview.chromium.org/2087893002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/tabs/tab_view.mm:73: NSImage* imageForResourceID(int
resource_id, bool heavy_stroke) {
nit: prefer enums over bool params,

imageForResourceId(IDR_FOO, NORMAL_STROKE)

reads easier than ..., false)

https://codereview.chromium.org/2087893002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/tabs/tab_view.mm:208:
NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification
(uber nit: i'd have a local constant with a much shorter name for this one, to
make the addObserver: call look a bit less ridiculous)

https://codereview.chromium.org/2087893002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/tabs/tab_view.mm:1006: + (void)setTabEdgeStrokeColor {
overriding static methods is a bit clever, maybe this could be an instance
method and a real object now. but up to you.

[Elly Fong-Jones, 2016-06-22 14:55:23]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-06-22 14:55:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2087893002/#ps40001
(title: "add enum StrokeStyle")

[commit-bot: I haz the power, 2016-06-22 14:55:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087893002/40001

[commit-bot: I haz the power, 2016-06-22 15:04:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 15:04:19]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Elly Fong-Jones, 2016-06-22 15:16:16]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-06-22 15:16:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2087893002/#ps60001
(title: "fix build break in cocoa unit tests")

[commit-bot: I haz the power, 2016-06-22 15:16:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087893002/60001

[Elly Fong-Jones, 2016-06-22 15:17:31]

The CQ bit was unchecked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-06-22 15:17:33]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-06-22 15:17:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087893002/60001

[commit-bot: I haz the power, 2016-06-22 16:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 16:28:58]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2016-06-22 17:26:32]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2016-06-22 17:26:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087893002/60001

[commit-bot: I haz the power, 2016-06-22 20:03:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-22 20:03:51]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2016-06-23 17:04:40]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2016-06-23 17:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org,
thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2087893002/#ps80001
(title: "fix 10.9 detection & themeless windows")

[commit-bot: I haz the power, 2016-06-23 17:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087893002/80001

[commit-bot: I haz the power, 2016-06-23 17:53:05]

Description was changed from

==========
[cocoa] increase tab strip contrast in "Increase Contrast" mode

With this change, when the "Increase Contrast" accessibility option is enabled:
1) The tab strip's bottom border is drawn in black instead of grey
2) Tab edges are drawn in black instead of grey
3) The active tab's title is bolded

BUG=619922
==========

to

==========
[cocoa] increase tab strip contrast in "Increase Contrast" mode

With this change, when the "Increase Contrast" accessibility option is enabled:
1) The tab strip's bottom border is drawn in black instead of grey
2) Tab edges are drawn in black instead of grey
3) The active tab's title is bolded

BUG=619922
==========

[commit-bot: I haz the power, 2016-06-23 17:53:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-23 17:55:17]

Description was changed from

==========
[cocoa] increase tab strip contrast in "Increase Contrast" mode

With this change, when the "Increase Contrast" accessibility option is enabled:
1) The tab strip's bottom border is drawn in black instead of grey
2) Tab edges are drawn in black instead of grey
3) The active tab's title is bolded

BUG=619922
==========

to

==========
[cocoa] increase tab strip contrast in "Increase Contrast" mode

With this change, when the "Increase Contrast" accessibility option is enabled:
1) The tab strip's bottom border is drawn in black instead of grey
2) Tab edges are drawn in black instead of grey
3) The active tab's title is bolded

BUG=619922

Committed: https://crrev.com/0877d7c2bf39b6179782438f55966754be8ef2a5
Cr-Commit-Position: refs/heads/master@{#401648}
==========

[commit-bot: I haz the power, 2016-06-23 17:55:19]

Patchset 5 (id:??) landed as
https://crrev.com/0877d7c2bf39b6179782438f55966754be8ef2a5
Cr-Commit-Position: refs/heads/master@{#401648}