Add test for trailing commas in parameter lists and argument lists.

Add test for trailing commas in parameter lists and argument lists.

Test is marked as failing for everyone.
When implementing the feature for a platform, the platform should mark itself
as no longer failing.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/f6d6792bc86dc6c864a99fd1bd0d3c5784e32e24

[Lasse Reichstein Nielsen, 2016-06-22 10:43:23]

lrn@google.com changed reviewers:
+ floitsch@google.com

[hausner, 2016-06-22 17:19:41]

hausner@google.com changed reviewers:
+ hausner@google.com

[hausner, 2016-06-22 17:19:42]

DBC: I would add cases that have extra commas after the closing ] or }, e.g.
foo(a, [b],)
Which, in the absence of an authoritative Spec, I presume should be a syntax
error.

https://codereview.chromium.org/2087863003/diff/1/tests/language/arg_param_tr...
File tests/language/arg_param_trailing_comma_test.dart (right):

https://codereview.chromium.org/2087863003/diff/1/tests/language/arg_param_tr...
tests/language/arg_param_trailing_comma_test.dart:120: // Call with ekstra comma
(not possible for setters and operators).
Dijkstra style comment :-)

[floitsch, 2016-06-22 18:23:39]

LGTM.

https://codereview.chromium.org/2087863003/diff/1/tests/language/arg_param_tr...
File tests/language/arg_param_trailing_comma_test.dart (right):

https://codereview.chromium.org/2087863003/diff/1/tests/language/arg_param_tr...
tests/language/arg_param_trailing_comma_test.dart:170: void topBadEmpty(,) {}   
                       /// 01: compile-time error
In theory, you would have a better test, if you only made the "," a compile time
error:

void topBadEmpty(
, /// 01: compile-time error
) {}

[Lasse Reichstein Nielsen, 2016-06-24 11:50:55]

I have added a lot more tests. PTAL.

https://codereview.chromium.org/2087863003/diff/1/tests/language/arg_param_tr...
File tests/language/arg_param_trailing_comma_test.dart (right):

https://codereview.chromium.org/2087863003/diff/1/tests/language/arg_param_tr...
tests/language/arg_param_trailing_comma_test.dart:120: // Call with ekstra comma
(not possible for setters and operators).
I regret nothing!

https://codereview.chromium.org/2087863003/diff/1/tests/language/arg_param_tr...
tests/language/arg_param_trailing_comma_test.dart:170: void topBadEmpty(,) {}   
                       /// 01: compile-time error
True, that would ensure that some other unintended error doesn't make the test
succeed incorrectly.

I have tried doing that, but it is also much less readable.
Having one complete test per line makes it easier to figure out what is failing
when it fails.

It's also not all cases where it makes sense, e.g. "foo([,])" is invalid with
and without the comma.

[floitsch, 2016-06-24 18:16:22]

Still LGTM.

https://codereview.chromium.org/2087863003/diff/20001/tests/language/arg_para...
File tests/language/arg_param_trailing_comma_test.dart (right):

https://codereview.chromium.org/2087863003/diff/20001/tests/language/arg_para...
tests/language/arg_param_trailing_comma_test.dart:12: // Trailing comma in
parameter litss.
lists

https://codereview.chromium.org/2087863003/diff/20001/tests/language/arg_para...
tests/language/arg_param_trailing_comma_test.dart:127: // Call with ekstra comma
(not possible for setters and operators).
I still think this should be fixed :)

[Lasse Reichstein Nielsen, 2016-06-27 06:58:52]

Description was changed from

==========
Add test for trailing commas in parameter lists and argument lists.

Test is marked as failing for everyone.
When implementing the feature for a platform, the platform should mark itself
as no longer failing.
==========

to

==========
Add test for trailing commas in parameter lists and argument lists.

Test is marked as failing for everyone.
When implementing the feature for a platform, the platform should mark itself
as no longer failing.

R=floitsch@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f6d6792bc86dc6c864a99fd1bd0d3c5784e32e24
==========

[Lasse Reichstein Nielsen, 2016-06-27 06:58:54]

Committed patchset #2 (id:20001) manually as
f6d6792bc86dc6c864a99fd1bd0d3c5784e32e24 (presubmit successful).