[stubs] GetPropertyStub added.

[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

GetPropertyStub is not used yet.

BUG=v8:4911
LOG=Y

Committed: https://crrev.com/e53f7d73f0e068d2272d1a7d71742f3c57e3a840
Cr-Commit-Position: refs/heads/master@{#37455}

[Igor Sheludko, 2016-06-21 15:31:55]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-21 15:32:49]

Description was changed from

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

GetPropertyStub is not used yet.

BUG=v8:4911
LOG=Y
==========

[Igor Sheludko, 2016-06-21 15:32:49]

Description was changed from

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

GetPropertyStub is not used yet.

BUG=v8:4911
LOG=Y
==========

[Igor Sheludko, 2016-06-21 15:32:56]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-21 15:33:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2087863002/20001

[Igor Sheludko, 2016-06-21 15:51:09]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-06-21 15:51:10]

PTAL

[commit-bot: I haz the power, 2016-06-21 16:06:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-21 16:06:27]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-22 10:52:54]

Patchset #2 (id:40001) has been deleted

[Toon Verwaest, 2016-06-23 12:48:22]

lgtm. Fairly complicated :)

https://codereview.chromium.org/2087863002/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2087863002/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2178: Int32Constant(FIRST_JS_RECEIVER_TYPE)),
LAST_SPECIAL_RECEIVER_TYPE or the other including JS_VALUE_TYPE if you support
elements.

[Igor Sheludko, 2016-06-28 08:09:07]

https://codereview.chromium.org/2087863002/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2087863002/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2178: Int32Constant(FIRST_JS_RECEIVER_TYPE)),
On 2016/06/23 12:48:22, Toon Verwaest wrote:
> LAST_SPECIAL_RECEIVER_TYPE or the other including JS_VALUE_TYPE if you support
> elements.

The existing own property/element lookups already support one special receiver
(global object) and some special elements (string wrappers) so I think this
receiver check is ok.

[Igor Sheludko, 2016-06-30 15:35:01]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-30 15:35:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 15:36:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 15:36:41]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/8377)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/8330)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18583)

[Igor Sheludko, 2016-06-30 16:14:02]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-06-30 16:14:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/2087863002/#ps60001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-06-30 16:14:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:38:33]

Description was changed from

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

GetPropertyStub is not used yet.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

GetPropertyStub is not used yet.

BUG=v8:4911
LOG=Y
==========

[commit-bot: I haz the power, 2016-06-30 16:38:34]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-06-30 16:40:35]

Description was changed from

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

GetPropertyStub is not used yet.

BUG=v8:4911
LOG=Y
==========

to

==========
[stubs] GetPropertyStub added.

Currently only property queries are supported.
This CL also factores out prototype chain iteration logic.

GetPropertyStub is not used yet.

BUG=v8:4911
LOG=Y

Committed: https://crrev.com/e53f7d73f0e068d2272d1a7d71742f3c57e3a840
Cr-Commit-Position: refs/heads/master@{#37455}
==========

[commit-bot: I haz the power, 2016-06-30 16:40:37]

Patchset 2 (id:??) landed as
https://crrev.com/e53f7d73f0e068d2272d1a7d71742f3c57e3a840
Cr-Commit-Position: refs/heads/master@{#37455}

[Benedikt Meurer, 2016-07-01 03:42:24]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-07-01 03:42:24]

Wohoo, awesome. Thanks Igor!