Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2087803003: Sync volume state using cras signal OutputNodeVolumeChanged. (Closed)

Created:
4 years, 6 months ago by jennyz
Modified:
4 years, 6 months ago
Reviewers:
hychao
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync volume state using cras signal OutputNodeVolumeChanged. BUG=614885 Committed: https://crrev.com/96526d0441d838fcbd07e7c38cd11e4314c52897 Cr-Commit-Position: refs/heads/master@{#401312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -21 lines) Patch
M chromeos/audio/cras_audio_handler.cc View 2 chunks +17 lines, -19 lines 0 comments Download
M chromeos/audio/cras_audio_handler_unittest.cc View 3 chunks +170 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_cras_audio_client.h View 1 chunk +10 lines, -1 line 0 comments Download
M chromeos/dbus/fake_cras_audio_client.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
jennyz
4 years, 6 months ago (2016-06-21 17:40:24 UTC) #1
jennyz
4 years, 6 months ago (2016-06-22 14:48:21 UTC) #4
hychao
lgtm
4 years, 6 months ago (2016-06-22 15:39:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087803003/1
4 years, 6 months ago (2016-06-22 16:23:37 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 17:04:08 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 17:06:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96526d0441d838fcbd07e7c38cd11e4314c52897
Cr-Commit-Position: refs/heads/master@{#401312}

Powered by Google App Engine
This is Rietveld 408576698