Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2087793002: GN: support cc_wrapper on Mac (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: support cc_wrapper on Mac Seems maybe the original CL just overlooked build/toolchain/mac/BUILD.gn? (https://codereview.chromium.org/1660053005) BUG= Committed: https://crrev.com/c56a9a3bbf9e905cc17a8d2c6e890e7a0ceb7cbb Cr-Commit-Position: refs/heads/master@{#401018}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M build/toolchain/mac/BUILD.gn View 8 chunks +20 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087793002/1
4 years, 6 months ago (2016-06-21 13:05:58 UTC) #2
mtklein_C
4 years, 6 months ago (2016-06-21 13:12:48 UTC) #5
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-21 16:35:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087793002/1
4 years, 6 months ago (2016-06-21 16:53:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 16:58:35 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 17:00:19 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c56a9a3bbf9e905cc17a8d2c6e890e7a0ceb7cbb
Cr-Commit-Position: refs/heads/master@{#401018}

Powered by Google App Engine
This is Rietveld 408576698