Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2087763002: New scenario and local benchmark - refactoring after change. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

New scenario and local benchmark - refactoring after change. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/929cdf8e026bff148dee61a98bf7115a0a3bda9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -0 lines) Patch
M pkg/analysis_server/benchmark/perf/benchmark_local.dart View 2 chunks +24 lines, -0 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_scenario.dart View 2 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-06-21 05:16:40 UTC) #1
Brian Wilkerson
lgtm
4 years, 6 months ago (2016-06-21 13:57:20 UTC) #2
scheglov
4 years, 6 months ago (2016-06-21 15:38:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
929cdf8e026bff148dee61a98bf7115a0a3bda9a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698