Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2087723002: Fix canonicalization of relative paths, Dart_DefaultCanonicalizeUrl expects the base)url to end wit… (Closed)

Created:
4 years, 6 months ago by siva
Modified:
4 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix canonicalization of relative paths, Dart_DefaultCanonicalizeUrl expects the base)url to end with a '/' when a directory is passed in otherwise it assumes a file path is passed in. Committed: https://github.com/dart-lang/sdk/commit/aca3d3eedffa7c1bef890f62fe8f1af15d4d4805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M runtime/bin/dartutils.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 6 months ago (2016-06-21 00:35:39 UTC) #2
siva
TBR=johnmccutchan
4 years, 6 months ago (2016-06-21 00:54:39 UTC) #3
siva
Committed patchset #1 (id:1) manually as aca3d3eedffa7c1bef890f62fe8f1af15d4d4805 (presubmit successful).
4 years, 6 months ago (2016-06-21 00:55:45 UTC) #5
Cutch
4 years, 6 months ago (2016-06-21 13:53:36 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698