Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2087683002: Extract media/capture/capture_unittests from media_unittests (Closed)

Created:
4 years, 6 months ago by mcasas
Modified:
4 years, 6 months ago
Reviewers:
brettw, xhwang, M-A Ruel, miu
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract media/capture/capture_unittests from media_unittests This CL: - extracts capture_unittests out of media_unittests. - adds it to all testing/buildbot/*.json where appropriate, i.e. where there is media_unittests. - adds the necessary .isolate and _apk.isolate. BUG=618718 TEST= No new code added, all bots running capture_unittests and being happy with it.¯ TBR=miu@chromium.org Committed: https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d Cr-Commit-Position: refs/heads/master@{#401692}

Patch Set 1 : correct an isolate path and removing stale MEDIA_EXPORT #

Patch Set 2 : Added capture_unittests to all recipes where there is media_unittests #

Patch Set 3 : Rebased (testing/buildbot/chromium.mac.json) #

Patch Set 4 : media/base/run_all_unittests.cc shouldn't know about RegisterCaptureJni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+628 lines, -26 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M build/all.gyp View 1 2 11 chunks +11 lines, -0 lines 0 comments Download
M media/BUILD.gn View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M media/base/run_all_unittests.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M media/capture/BUILD.gn View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M media/capture/capture.gyp View 3 chunks +87 lines, -8 lines 0 comments Download
A media/capture/capture_unittests.isolate View 1 chunk +62 lines, -0 lines 0 comments Download
A media/capture/capture_unittests_apk.isolate View 1 chunk +18 lines, -0 lines 0 comments Download
M media/capture/video/android/photo_capabilities.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/media.gyp View 3 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.android.json View 1 2 10 chunks +50 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 39 chunks +213 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 6 chunks +41 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 2 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 2 3 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 2 8 chunks +29 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webrtc.json View 1 3 chunks +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webrtc.fyi.json View 1 7 chunks +7 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 4 chunks +24 lines, -0 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 1 chunk +6 lines, -0 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 36 (21 generated)
mcasas
xhwang@ PTAL at media/* miu@ PTAL at the changes in media/capture/* maruel@ PTAL at testing/builbot/* ...
4 years, 6 months ago (2016-06-21 23:54:54 UTC) #9
M-A Ruel
lgtm Removed the following from the CL description: > I'm uncertain if this needs changing ...
4 years, 6 months ago (2016-06-22 00:04:14 UTC) #11
xhwang
Thanks for closing the loop. LGTM!
4 years, 6 months ago (2016-06-22 04:59:20 UTC) #12
mcasas
brettw@ RS the two top level build files plz
4 years, 6 months ago (2016-06-22 15:50:31 UTC) #14
mcasas
brettw@ RS the top level files please.
4 years, 6 months ago (2016-06-22 15:54:39 UTC) #16
brettw
rs lgtm
4 years, 6 months ago (2016-06-22 18:22:59 UTC) #17
mcasas
On 2016/06/22 18:22:59, brettw wrote: > rs lgtm miu@ ping
4 years, 6 months ago (2016-06-22 18:32:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087683002/80001
4 years, 6 months ago (2016-06-23 13:31:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/25508) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-23 13:32:52 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087683002/100001
4 years, 6 months ago (2016-06-23 15:42:17 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/92626)
4 years, 6 months ago (2016-06-23 16:52:17 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087683002/120001
4 years, 6 months ago (2016-06-23 18:52:47 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:120001)
4 years, 6 months ago (2016-06-23 19:52:26 UTC) #33
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d Cr-Commit-Position: refs/heads/master@{#401692}
4 years, 6 months ago (2016-06-23 19:55:47 UTC) #35
mcasas
4 years, 6 months ago (2016-06-23 21:15:53 UTC) #36
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:120001) has been created in
https://codereview.chromium.org/2093563004/ by mcasas@chromium.org.

The reason for reverting is: Broke Win x64 bot 
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1849

FAILED: audio_unittests.exe audio_unittests.exe.pdb 
C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests
environment.x64 True audio_unittests.exe
"C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper
environment.x64 False link.exe /nologo /OUT:audio_unittests.exe
@audio_unittests.exe.rsp" 1 mt.exe rc.exe
"obj\media\audio_unittests.audio_unittests.exe.intermediate.manifest"
obj\media\audio_unittests.audio_unittests.exe.generated.manifest
..\..\build\win\compatibility.manifest
media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external
symbol CLSID_DxDiagProvider referenced in function "public: static bool __cdecl
media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > *,class
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char>
> *)"
(?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z)

media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external
symbol IID_IDxDiagProvider referenced in function "public: static bool __cdecl
media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > *,class
std::basic_string<char,struct std::char_traits<char>,class std::allocator<char>
> *)"
(?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z)

audio_unittests.exe : fatal error LNK1120: 2 unresolved externals
.

Powered by Google App Engine
This is Rietveld 408576698