Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Issue 2087663002: Simplify logic involving BackTexture. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp91
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify logic involving BackTexture. No intended behavior change. This CL removes the member |offscreen_saved_color_texture_info_| by giving each BackTexture a TextureRef member. This simplifies logic surrounding BackTexture, and is necessary to support Image-backed BackTextures. BUG=602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/3dec65ce8a52354cf041ac572ba5f50681f1b575 Cr-Commit-Position: refs/heads/master@{#401151}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : More cleanup. #

Patch Set 4 : Minor fix. #

Patch Set 5 : Fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -121 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 25 chunks +82 lines, -119 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 4 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087663002/1
4 years, 6 months ago (2016-06-20 21:57:19 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/84007) android_clang_dbg_recipe on ...
4 years, 6 months ago (2016-06-20 22:03:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087663002/20001
4 years, 6 months ago (2016-06-20 22:19:08 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_gpu_tests_rel/builds/887)
4 years, 6 months ago (2016-06-20 23:27:41 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087663002/40001
4 years, 6 months ago (2016-06-20 23:51:52 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/249342)
4 years, 6 months ago (2016-06-21 00:43:16 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087663002/60001
4 years, 6 months ago (2016-06-21 18:03:02 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/231742)
4 years, 6 months ago (2016-06-21 18:51:18 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087663002/80001
4 years, 6 months ago (2016-06-21 19:58:18 UTC) #19
erikchen
piman: Please review.
4 years, 6 months ago (2016-06-21 21:44:36 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-21 22:00:02 UTC) #25
piman
lgtm
4 years, 6 months ago (2016-06-22 00:56:36 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087663002/80001
4 years, 6 months ago (2016-06-22 00:59:44 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-22 01:05:50 UTC) #30
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 01:08:20 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3dec65ce8a52354cf041ac572ba5f50681f1b575
Cr-Commit-Position: refs/heads/master@{#401151}

Powered by Google App Engine
This is Rietveld 408576698