Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2087653003: DevTools:Don't lowercase SVG and other XML-like elements (Closed)

Created:
4 years, 6 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't lowercase SVG and other XML-like elements BUG=614171 Committed: https://crrev.com/eaaec7148620764d61412022338beebb69ad61d5 Cr-Commit-Position: refs/heads/master@{#402301}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Reformat test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -17 lines) Patch
A + third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html View 1 2 chunks +16 lines, -16 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case-expected.txt View 1 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
einbinder
You can test with data:text/html,<svg><feComposite>
4 years, 6 months ago (2016-06-20 23:34:54 UTC) #2
dgozman
https://codereview.chromium.org/2087653003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html File third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html (right): https://codereview.chromium.org/2087653003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html#newcode3 third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html:3: <head> Please follow the formatting of nearby tests. https://codereview.chromium.org/2087653003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js ...
4 years, 6 months ago (2016-06-20 23:58:52 UTC) #4
einbinder
https://codereview.chromium.org/2087653003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html File third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html (right): https://codereview.chromium.org/2087653003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html#newcode3 third_party/WebKit/LayoutTests/inspector/elements/elements-panel-correct-case.html:3: <head> On 2016/06/20 23:58:52, dgozman wrote: > Please follow ...
4 years, 6 months ago (2016-06-21 00:20:51 UTC) #5
dgozman
lgtm
4 years, 6 months ago (2016-06-21 00:37:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2087653003/20001
4 years, 5 months ago (2016-06-27 18:54:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/192319)
4 years, 5 months ago (2016-06-27 19:17:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2087653003/20001
4 years, 5 months ago (2016-06-27 19:34:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 21:49:33 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 21:51:43 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eaaec7148620764d61412022338beebb69ad61d5
Cr-Commit-Position: refs/heads/master@{#402301}

Powered by Google App Engine
This is Rietveld 408576698