Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.h

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to gyp files, IWYU for #ifdef (OS_MACOSX). Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_modal/web_contents_modal_dialog_manager.h
diff --git a/components/web_modal/web_contents_modal_dialog_manager.h b/components/web_modal/web_contents_modal_dialog_manager.h
index 6505301c215f73fa3e250b800f239dd3de988208..9d964d1c4edc46fdf58cac519245bf22759850fc 100644
--- a/components/web_modal/web_contents_modal_dialog_manager.h
+++ b/components/web_modal/web_contents_modal_dialog_manager.h
@@ -9,6 +9,7 @@
#include <memory>
#include "base/macros.h"
+#include "build/build_config.h"
#include "components/web_modal/single_web_contents_dialog_manager.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
@@ -29,13 +30,13 @@ class WebContentsModalDialogManager
WebContentsModalDialogManagerDelegate* delegate() const { return delegate_; }
void SetDelegate(WebContentsModalDialogManagerDelegate* d);
+#if defined(OS_MACOSX)
+ // Note: This method is not defined inside components/web_modal/ as its
+ // definition (needed for Cocoa builds) depends on chrome/browser/ui/cocoa/.
static SingleWebContentsDialogManager* CreateNativeWebModalManager(
gfx::NativeWindow dialog,
SingleWebContentsDialogManagerDelegate* native_delegate);
-
- // Shows the dialog as a web contents modal dialog. The dialog will notify via
- // WillClose() when it is being destroyed.
- void ShowModalDialog(gfx::NativeWindow dialog);
+#endif
// Allow clients to supply their own native dialog manager. Suitable for
// bubble clients.

Powered by Google App Engine
This is Rietveld 408576698