components/constrained_window/constrained_window_views.cc - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/constrained_window/constrained_window_views.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert changes to gyp files, IWYU for #ifdef (OS_MACOSX). Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/constrained_window/constrained_window_views.h ('k') | components/constrained_window/native_web_contents_modal_dialog_manager_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/constrained_window/constrained_window_views.cc

diff --git a/components/constrained_window/constrained_window_views.cc b/components/constrained_window/constrained_window_views.cc

index def5232fc9782603559d380c6499264f1c8ac6b5..37d580988a66721c7a47080dc5be34df2daf7d23 100644

--- a/components/constrained_window/constrained_window_views.cc

+++ b/components/constrained_window/constrained_window_views.cc

@@ -141,8 +141,7 @@ views::Widget* ShowWebModalDialogViews(

content::WebContents* web_contents =

guest_view::GuestViewBase::GetTopLevelWebContents(initiator_web_contents);

views::Widget* widget = CreateWebModalDialogViews(dialog, web_contents);

- web_modal::WebContentsModalDialogManager::FromWebContents(web_contents)

- ->ShowModalDialog(widget->GetNativeWindow());

+ ShowModalDialog(widget->GetNativeWindow(), web_contents);

return widget;

}