Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: components/constrained_window/BUILD.gn

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to gyp files, IWYU for #ifdef (OS_MACOSX). Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | components/constrained_window/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/constrained_window/BUILD.gn
diff --git a/components/constrained_window/BUILD.gn b/components/constrained_window/BUILD.gn
index ddb6b29354bca439d4c308c6ae292c67d0d9db07..fd5f938e9d6df76237031d3f88716317c198b8f6 100644
--- a/components/constrained_window/BUILD.gn
+++ b/components/constrained_window/BUILD.gn
@@ -2,19 +2,40 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/ui.gni")
+
static_library("constrained_window") {
sources = [
"constrained_window_views.cc",
"constrained_window_views.h",
"constrained_window_views_client.h",
+ "native_web_contents_modal_dialog_manager_views.cc",
+ "native_web_contents_modal_dialog_manager_views.h",
]
+ if (is_mac && !mac_views_browser) {
+ sources += [ "show_modal_dialog_cocoa.cc" ]
+ } else {
+ sources += [ "show_modal_dialog_views.cc" ]
+ }
+
deps = [
"//components/guest_view/browser",
"//components/web_modal",
- "//skia",
+ "//content/public/browser",
"//ui/views",
]
+ public_deps = [
+ # Skia headers are exposed in the public API.
+ "//skia",
+ ]
+
+ if (use_aura) {
+ deps += [
+ "//ui/aura",
+ "//ui/wm",
+ ]
+ }
}
source_set("unit_tests") {
@@ -23,6 +44,10 @@ source_set("unit_tests") {
"constrained_window_views_unittest.cc",
]
+ if (is_mac && !mac_views_browser) {
+ sources += [ "test_create_native_web_modal_manager_cocoa.cc" ]
+ }
+
deps = [
":constrained_window",
"//components/web_modal:test_support",
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | components/constrained_window/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698