chrome/chrome_browser_ui.gypi - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc ('k') | components/constrained_window.gypi » ('j') | components/constrained_window.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index 23f3d83100a1cf5121dd4b65ef4f775fc2b452b3..77daa2b8f1482c5bc500f7394a421eb4f7514c39 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -793,7 +793,7 @@

'browser/ui/webui/chromeos/emulator/device_emulator_ui.cc',

'browser/ui/webui/chromeos/emulator/device_emulator_ui.h',

- # Mac sources, except when mac_views_browser==1

+ # Mac sources, except when mac_views_browser==1.

'chrome_browser_ui_cocoa_sources': [

'browser/ui/cocoa/animatable_image.h',

'browser/ui/cocoa/animatable_image.mm',

@@ -2420,8 +2420,6 @@

'browser/ui/views/location_bar/zoom_bubble_view.h',

'browser/ui/views/location_bar/zoom_view.cc',

'browser/ui/views/location_bar/zoom_view.h',

- 'browser/ui/views/native_web_contents_modal_dialog_manager_views.cc',

- 'browser/ui/views/native_web_contents_modal_dialog_manager_views.h',

'browser/ui/views/omnibox/omnibox_popup_contents_view.cc',

'browser/ui/views/omnibox/omnibox_popup_contents_view.h',

'browser/ui/views/omnibox/omnibox_result_view.cc',

@@ -2539,7 +2537,6 @@

'browser/ui/views/update_recommended_message_box.h',

'browser/ui/views/validation_message_bubble_view.cc',

'browser/ui/views/validation_message_bubble_view.h',

- 'browser/ui/views/web_contents_modal_dialog_manager_views.cc',

'browser/ui/views/website_settings/chooser_bubble_ui_view.cc',

'browser/ui/views/website_settings/chooser_bubble_ui_view.h',

'browser/ui/views/website_settings/permission_prompt_impl_views.cc',