chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert NativeManagerTracker split, delete CreateNativeWebModalManager impls w/ two left for Cocoa a… Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/web_contents_modal_dialog_manager_views_mac_browsertest.mm ('k') | chrome/browser/ui/views/native_web_contents_modal_dialog_manager_views.h » ('j') | components/constrained_window.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

diff --git a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

index 0644dbcd853cb5c3181f4e392995a3b65d5b1156..73e38928140ec94aa6259f00c38e894ebbbffdd5 100644

--- a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

+++ b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

@@ -238,9 +238,8 @@ class ConstrainedWebDialogDelegateViewViews

}

void DocumentOnLoadCompletedInMainFrame() override {

if (!max_size_.IsEmpty() && initiator_observer_.web_contents()) {

- web_modal::WebContentsModalDialogManager::FromWebContents(

- initiator_observer_.web_contents())

- ->ShowModalDialog(GetWidget()->GetNativeWindow());

+ constrained_window::ShowModalDialog(GetWidget()->GetNativeWindow(),

+ initiator_observer_.web_contents());

}