components/constrained_window/test_create_native_web_modal_manager_cocoa.cc - Issue 2087643003: Move web modal dialog manager files into the constrained_window component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/constrained_window/test_create_native_web_modal_manager_cocoa.cc

Issue 2087643003: Move web modal dialog manager files into the constrained_window component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert changes to gyp files, IWYU for #ifdef (OS_MACOSX). Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/web_modal/web_contents_modal_dialog_manager.h"	5 #include "components/web_modal/web_contents_modal_dialog_manager.h"

6	6

7 namespace web_modal {	7 namespace web_modal {

8	8

9 SingleWebContentsDialogManager*	9 SingleWebContentsDialogManager*

10 WebContentsModalDialogManager::CreateNativeWebModalManager(	10 WebContentsModalDialogManager::CreateNativeWebModalManager(

11 gfx::NativeWindow dialog,	11 gfx::NativeWindow dialog,

12 SingleWebContentsDialogManagerDelegate* native_delegate) {	12 web_modal::SingleWebContentsDialogManagerDelegate* delegate) {

13 // TODO(oshima): Investigate if we need to implement this.	13 return nullptr;

14 NOTREACHED();

15 return NULL;

16 }	14 }

17	15

18 } // namespace web_modal	16 } // namespace web_modal

OLD	NEW