Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2087633002: Defines TriggerConditions and plumbs up to BackgroundScheduler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Exposed TriggerConditions object for test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_coordinator_unittest.cc
diff --git a/components/offline_pages/background/request_coordinator_unittest.cc b/components/offline_pages/background/request_coordinator_unittest.cc
index ebcbe140f39a7b3f1a30b8ffbf8e619d52ed20f4..14e096e0eaa92298fc609ba78dd005c48341da46 100644
--- a/components/offline_pages/background/request_coordinator_unittest.cc
+++ b/components/offline_pages/background/request_coordinator_unittest.cc
@@ -33,10 +33,14 @@ const int kRequestId(1);
class SchedulerStub : public Scheduler {
public:
- SchedulerStub() : schedule_called_(false), unschedule_called_(false) {}
+ SchedulerStub()
+ : schedule_called_(false),
+ unschedule_called_(false),
+ conditions_(false, 0, false) {}
- void Schedule(const TriggerCondition& trigger_condition) override {
+ void Schedule(const TriggerConditions& trigger_conditions) override {
schedule_called_ = true;
+ conditions_ = trigger_conditions;
}
// Unschedules the currently scheduled task, if any.
@@ -48,9 +52,12 @@ class SchedulerStub : public Scheduler {
bool unschedule_called() const { return unschedule_called_; }
+ TriggerConditions const* conditions() const { return &conditions_; }
+
private:
bool schedule_called_;
bool unschedule_called_;
+ TriggerConditions conditions_;
};
class OfflinerStub : public Offliner {
@@ -195,6 +202,10 @@ TEST_F(RequestCoordinatorTest, SavePageLater) {
SchedulerStub* scheduler_stub = reinterpret_cast<SchedulerStub*>(
coordinator()->scheduler());
EXPECT_TRUE(scheduler_stub->schedule_called());
+ EXPECT_EQ(coordinator()
+ ->GetTriggerConditionsForUserRequest()
+ .minimum_battery_percentage,
+ scheduler_stub->conditions()->minimum_battery_percentage);
}
TEST_F(RequestCoordinatorTest, OfflinerDoneRequestSucceeded) {
« no previous file with comments | « components/offline_pages/background/request_coordinator.cc ('k') | components/offline_pages/background/scheduler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698