Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 208763003: Enable WebAudio by default for Android/x86. (Closed)

Created:
6 years, 9 months ago by Raymond Toy (Google)
Modified:
6 years, 8 months ago
Reviewers:
cmp, jam, Raymond Toy
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Enable WebAudio by default for Android/x86. about:flags now has a disable WebAudio flag on Android for x86, just like for arm, as expected. I manually tested that the flag does disable WebAudio. I verified that on desktop (linux), there is no disable (or enable) flag, as expected. (Desktop always has WebAudio enabled, and there is no flag to disable it.) BUG=353809 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260429

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -46 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download
M content/child/runtime_features.cc View 1 2 chunks +5 lines, -13 lines 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Raymond Toy
PTAL at this relatively small change to enable WebAudio by default on Android/x86. The various ...
6 years, 9 months ago (2014-03-25 16:39:09 UTC) #1
jam
https://codereview.chromium.org/208763003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/208763003/diff/1/chrome/browser/about_flags.cc#newcode571 chrome/browser/about_flags.cc:571: #if defined(ARCH_CPU_ARMEL) || defined(ARCH_CPU_X86) is this ifdef actually needed? ...
6 years, 9 months ago (2014-03-25 17:44:09 UTC) #2
Raymond Toy
https://codereview.chromium.org/208763003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/208763003/diff/1/chrome/browser/about_flags.cc#newcode571 chrome/browser/about_flags.cc:571: #if defined(ARCH_CPU_ARMEL) || defined(ARCH_CPU_X86) On 2014/03/25 17:44:09, jam wrote: ...
6 years, 9 months ago (2014-03-25 17:53:04 UTC) #3
jam
lgtm
6 years, 9 months ago (2014-03-25 19:23:11 UTC) #4
Raymond Toy
The CQ bit was checked by rtoy@chromium.org
6 years, 9 months ago (2014-03-27 20:37:17 UTC) #5
Raymond Toy
On 2014/03/25 19:23:11, jam wrote: > lgtm Thanks!
6 years, 9 months ago (2014-03-27 20:37:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/208763003/90001
6 years, 9 months ago (2014-03-27 20:37:50 UTC) #7
cmp
The CQ bit was unchecked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:14:00 UTC) #8
cmp
The CQ bit was checked by cmp@chromium.org
6 years, 8 months ago (2014-03-30 16:16:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/208763003/90001
6 years, 8 months ago (2014-03-30 16:16:18 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-03-30 16:50:54 UTC) #11
Message was sent while issue was closed.
Change committed as 260429

Powered by Google App Engine
This is Rietveld 408576698