Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2087623002: Move AccessibilityHighlightManagerTest to interactive_ui_tests (Closed)

Created:
4 years, 6 months ago by dmazzoni
Modified:
4 years, 6 months ago
Reviewers:
James Cook
CC:
chromium-reviews, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, xiyuan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AccessibilityHighlightManagerTest to interactive_ui_tests Other tests that take a pixel snapshot seem to be there, hopefully it will be less flaky. BUG=609173, 314889, 621306 Committed: https://crrev.com/812f9f71170ea1d810237807c8d7f664ddc9ed2c Cr-Commit-Position: refs/heads/master@{#400808}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Initialize two variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -224 lines) Patch
D chrome/browser/chromeos/accessibility/accessibility_highlight_manager_browsertest.cc View 1 chunk +0 lines, -221 lines 0 comments Download
A + chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dmazzoni
4 years, 6 months ago (2016-06-20 21:13:05 UTC) #2
James Cook
lgtm
4 years, 6 months ago (2016-06-20 21:16:49 UTC) #3
James Cook
https://codereview.chromium.org/2087623002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc File chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc (right): https://codereview.chromium.org/2087623002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc#newcode141 chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc:141: int diff_count_; nit: This and the line below should ...
4 years, 6 months ago (2016-06-20 21:17:27 UTC) #4
dmazzoni
https://codereview.chromium.org/2087623002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc File chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc (right): https://codereview.chromium.org/2087623002/diff/1/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc#newcode141 chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc:141: int diff_count_; On 2016/06/20 21:17:27, James Cook wrote: > ...
4 years, 6 months ago (2016-06-20 21:23:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087623002/20001
4 years, 6 months ago (2016-06-20 21:23:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 22:10:58 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 22:13:32 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/812f9f71170ea1d810237807c8d7f664ddc9ed2c
Cr-Commit-Position: refs/heads/master@{#400808}

Powered by Google App Engine
This is Rietveld 408576698