Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2087553002: Add regression tests. (Closed)

Created:
4 years, 6 months ago by ahe
Modified:
4 years, 6 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@this_call
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reset library loader after crash. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M lib/custom_compiler.dart View 1 2 chunks +5 lines, -0 lines 0 comments Download
A + test/kernel/regression/issue_000043.dart View 1 chunk +1 line, -5 lines 0 comments Download
A + test/kernel/regression/issue_000044.dart View 1 chunk +1 line, -3 lines 0 comments Download
A + test/kernel/regression/issue_000045.dart View 1 chunk +1 line, -3 lines 0 comments Download
A + test/kernel/regression/issue_000046.dart View 1 chunk +1 line, -5 lines 0 comments Download
A + test/kernel/regression/issue_000047.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M test/rasta.status View 1 chunk +6 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (2 generated)
ahe
4 years, 6 months ago (2016-06-20 18:10:04 UTC) #2
kasperl
LGTM.
4 years, 6 months ago (2016-06-20 20:13:51 UTC) #3
ahe
4 years, 6 months ago (2016-06-21 11:20:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bfd9c1ba187bcf14cde7a79ba76c02983007fcbe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698