chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java - Issue 2087543002: Changed NavigationController access to through tab in Java code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 2087543002: Changed NavigationController access to through tab in Java code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed interface to NavigationHandler Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

index 6dc4385b1c2b8e892f42e4f6e2683bd2f8fa9e01..2ccefe712e54428283d129d44751f583a389ca6d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

@@ -262,9 +262,9 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {

private void displayNavigationPopup(boolean isForward, View anchorView) {

Tab tab = getToolbarDataProvider().getTab();

- if (tab == null || tab.getWebContents() == null) return;

- mNavigationPopup = new NavigationPopup(tab.getProfile(), getContext(),

- tab.getWebContents().getNavigationController(), isForward);

+ if (tab == null || tab.getNavigationHandler() == null) return;

+ mNavigationPopup = new NavigationPopup(

+ tab.getProfile(), getContext(), tab.getNavigationHandler(), isForward);

mNavigationPopup.setAnchorView(anchorView);

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »