chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java - Issue 2087543002: Changed NavigationController access to through tab in Java code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

Issue 2087543002: Changed NavigationController access to through tab in Java code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed interface to NavigationHandler Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/navigation/NavigationHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

index 28e4ab37cc4e1b8f2fff7979ed17febf77baf2bb..5ea5ea3ac893886f989ce6c4e0cb83bdbb352756 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java

@@ -18,7 +18,6 @@ import org.chromium.chrome.browser.tabmodel.TabModel;

import org.chromium.chrome.browser.tabmodel.TabModelSelector;

import org.chromium.chrome.browser.tabmodel.TabModelSelectorTabObserver;

import org.chromium.components.variations.VariationsAssociatedData;

-import org.chromium.content_public.browser.WebContents;

import org.chromium.net.NetworkChangeNotifier;

/**

@@ -53,9 +52,8 @@ public class UmaSessionStats implements NetworkChangeNotifier.ConnectionTypeObse

}

private void recordPageLoadStats(Tab tab) {

- WebContents webContents = tab.getWebContents();

- boolean isDesktopUserAgent = webContents != null

- && webContents.getNavigationController().getUseDesktopUserAgent();

+ boolean isDesktopUserAgent = tab.getNavigationHandler() != null

+ && tab.getNavigationHandler().getUseDesktopUserAgent();

nativeRecordPageLoaded(isDesktopUserAgent);

if (mKeyboardConnected) {

nativeRecordPageLoadedWithKeyboard();