Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2087513003: Remove LayoutBlockFlow overflow invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix InlineTextBoxTest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index 915e7e4c6115a034120284471ad4ff2d47eec0ef..22334c6707e616068072e324a9d7fb3b32dc51e7 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -1552,16 +1552,6 @@ void LayoutObject::fullyInvalidatePaint(const LayoutBoxModelObject& paintInvalid
invalidatePaintUsingContainer(paintInvalidationContainer, invalidationRect, invalidationReason);
}
-void LayoutObject::invalidatePaintForOverflow()
-{
-}
-
-void LayoutObject::invalidatePaintForOverflowIfNeeded()
-{
- if (shouldInvalidateOverflowForPaint())
- invalidatePaintForOverflow();
-}
-
LayoutRect LayoutObject::absoluteClippedOverflowRect() const
{
LayoutRect rect = localOverflowRectForPaintInvalidation();
@@ -1838,13 +1828,8 @@ void LayoutObject::firstLineStyleDidChange(const ComputedStyle& oldStyle, const
firstLineContainer = toLayoutBlockFlow(containingBlock());
}
}
- if (firstLineContainer) {
- firstLineContainer->invalidateDisplayItemClientsOfFirstLine();
- // The following is for rect invalidation. For slimming paint v2, we can invalidate the rects
- // of the first line display item clients instead of the whole rect of the container.
- if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled())
- firstLineContainer->setShouldDoFullPaintInvalidation();
- }
+ if (firstLineContainer)
+ firstLineContainer->setShouldDoFullPaintInvalidationForFirstLine();
}
if (diff.needsLayout())
setNeedsLayoutAndPrefWidthsRecalc(LayoutInvalidationReason::StyleChange);
@@ -3431,7 +3416,6 @@ void LayoutObject::clearPaintInvalidationFlags(const PaintInvalidationState& pai
clearShouldDoFullPaintInvalidation();
m_bitfields.setChildShouldCheckForPaintInvalidation(false);
m_bitfields.setNeededLayoutBecauseOfChildren(false);
- m_bitfields.setShouldInvalidateOverflowForPaint(false);
m_bitfields.setMayNeedPaintInvalidation(false);
m_bitfields.setMayNeedPaintInvalidationSubtree(false);
m_bitfields.setShouldInvalidateSelection(false);

Powered by Google App Engine
This is Rietveld 408576698