Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2087513003: Remove LayoutBlockFlow overflow invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix InlineTextBoxTest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
index 4734a256b2c10ec09f4f7c63175e3f9a8088259c..1ed48cc56e0d5a468c3ff3145de826e4d4162f03 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
@@ -288,7 +288,7 @@ public:
return containsFloats() ? m_floatingObjects->set().last().get() : nullptr;
}
- void invalidateDisplayItemClientsOfFirstLine();
+ void setShouldDoFullPaintInvalidationForFirstLine();
void simplifiedNormalFlowInlineLayout();
bool recalcInlineChildrenOverflowAfterStyleChange();
@@ -303,7 +303,7 @@ public:
protected:
void rebuildFloatsFromIntruding();
- void layoutInlineChildren(bool relayoutChildren, LayoutUnit& paintInvalidationLogicalTop, LayoutUnit& paintInvalidationLogicalBottom, LayoutUnit afterEdge);
+ void layoutInlineChildren(bool relayoutChildren, LayoutUnit afterEdge);
void addLowestFloatFromChildren(LayoutBlockFlow*);
void createFloatingObjects();
@@ -379,7 +379,6 @@ private:
bool hitTestFloats(HitTestResult&, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset);
void invalidatePaintForOverhangingFloats(bool paintAllDescendants) final;
- void invalidatePaintForOverflow() final;
void invalidateDisplayItemClients(PaintInvalidationReason) const override;
void clearFloats(EClear);
@@ -609,9 +608,6 @@ private:
LayoutBlockFlowRareData& ensureRareData();
- LayoutUnit m_paintInvalidationLogicalTop;
- LayoutUnit m_paintInvalidationLogicalBottom;
-
bool isSelfCollapsingBlock() const override;
bool checkIfIsSelfCollapsingBlock() const;

Powered by Google App Engine
This is Rietveld 408576698