Remove LayoutBlockFlow overflow invalidation

third_party/WebKit/Source/core/layout/line/InlineBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 47 matching lines @@
     if (!m_hasBadParent && m_parent)
         m_parent->setHasBadChildList();
 }
 
 #endif
 
 void InlineBox::destroy()
 {
     // We do not need to issue invalidations if the page is being destroyed
     // since these objects will never be repainted.
-    // TODO(crbug.com/619630): Make this fast.
-    if (!m_lineLayoutItem.documentBeingDestroyed())
-        m_lineLayoutItem.slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(*this, PaintInvalidationFull);
+    if (!m_lineLayoutItem.documentBeingDestroyed()) {
+        setLineLayoutItemShouldDoFullPaintInvalidationIfNeeded();
+
+#if CHECK_DISPLAY_ITEM_CLIENT_ALIVENESS
+        // This object may have display items in a cached subsequence, but we are
+        // sure that the subsequence will be invalidated because m_lineLayoutItem has
+        // been setShouldFullPaintInvalidation(), so deletion of this object is safe.
+        endShouldKeepAlive();
+#endif
+    }
+
     delete this;
 }
 
 void InlineBox::remove(MarkLineBoxes markLineBoxes)
 {
     if (parent())
         parent()->removeChild(this, markLineBoxes);
 }
 
 void* InlineBox::operator new(size_t sz)
@@ skipping 126 matching lines @@
     if (getLineLayoutItem().isBox())
         LineLayoutBox(getLineLayoutItem()).setInlineBoxWrapper(this);
 }
 
 void InlineBox::move(const LayoutSize& delta)
 {
     m_topLeft.move(delta);
 
     if (getLineLayoutItem().isAtomicInlineLevel())
         LineLayoutBox(getLineLayoutItem()).move(delta.width(), delta.height());
+
+    setLineLayoutItemShouldDoFullPaintInvalidationIfNeeded();
 }
 
 void InlineBox::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit /* lineTop */, LayoutUnit /* lineBottom */) const
 {
     BlockPainter::paintInlineBox(*this, paintInfo, paintOffset);
 }
 
 bool InlineBox::nodeAtPoint(HitTestResult& result, const HitTestLocation& locationInContainer, const LayoutPoint& accumulatedOffset, LayoutUnit /* lineTop */, LayoutUnit /* lineBottom */)
 {
     // Hit test all phases of replaced elements atomically, as though the replaced element established its
@@ skipping 149 matching lines @@
     root().block().flipForWritingMode(rect);
 }
 
 LayoutPoint InlineBox::flipForWritingMode(const LayoutPoint& point) const
 {
     if (!UNLIKELY(getLineLayoutItem().hasFlippedBlocksWritingMode()))
         return point;
     return root().block().flipForWritingMode(point);
 }
 
-void InlineBox::invalidateDisplayItemClientsRecursively()
+void InlineBox::setShouldDoFullPaintInvalidationRecursively()
 {
-    // TODO(crbug.com/619630): Make this fast.
-    getLineLayoutItem().slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(*this, PaintInvalidationFull);
+    getLineLayoutItem().setShouldDoFullPaintInvalidation();
     if (!isInlineFlowBox())
         return;
     for (InlineBox* child = toInlineFlowBox(this)->firstChild(); child; child = child->nextOnLine())
-        child->invalidateDisplayItemClientsRecursively();
+        child->setShouldDoFullPaintInvalidationRecursively();
+}
+
+void InlineBox::setLineLayoutItemShouldDoFullPaintInvalidationIfNeeded()
+{
+    // For RootInlineBox, we only need to invalidate if it's using the first line style.
+    // otherwise it paints nothing so we don't need to invalidate it.
+    if (!isRootInlineBox() || isFirstLineStyle())
+        m_lineLayoutItem.setShouldDoFullPaintInvalidation();
 }
 
 } // namespace blink
 
 #ifndef NDEBUG
 
 void showTree(const blink::InlineBox* b)
 {
     if (b)
         b->showTreeForThis();
     else
         fprintf(stderr, "Cannot showTree for (nil) InlineBox.\n");
 }
 
 void showLineTree(const blink::InlineBox* b)
 {
     if (b)
         b->showLineTreeForThis();
     else
         fprintf(stderr, "Cannot showLineTree for (nil) InlineBox.\n");
 }
 
 #endif