telemetry/telemetry/value/summary.py - Issue 2087463002: [telemetry] Fix computation of standard deviations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/summary.py

Issue 2087463002: [telemetry] Fix computation of standard deviations (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix more unit tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/value/summary.py

diff --git a/telemetry/telemetry/value/summary.py b/telemetry/telemetry/value/summary.py

index 5dde5c9b9a2a7bb0ca5bc47df825563b59a7aeeb..3043f6d44ac7571569c5173fa223788aef1d8131 100644

--- a/telemetry/telemetry/value/summary.py

+++ b/telemetry/telemetry/value/summary.py

@@ -111,7 +111,7 @@ class Summary(object):

merged_pages_value_by_key = {}

if not self.had_failures:

for value in merge_values.MergeLikeValuesFromDifferentPages(

- all_successful_page_values, self._key_func):

+ merged_page_values, self._key_func):

value_key = self._key_func(value)

assert value_key not in merged_pages_value_by_key

merged_pages_value_by_key[value_key] = value