Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2087453003:
Benchmark rotated rect with AA/noAA (Closed)
DescriptionBenchmark rotated rect with AA/noAA
Using this benchmark, we verify that AA is about 4x slower than noAA in
path_fill_big_rotated_rect. This is what I aim to improve in the next
CL.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003
Committed: https://skia.googlesource.com/skia/+/a27f669f460e9186dbb3ebe3e9323acef95d41b8
Patch Set 1 #Patch Set 2 : Parent #Patch Set 3 : Scalar #Messages
Total messages: 19 (11 generated)
Description was changed from ========== Benchmark rotated rect with AA/noAA Using this benchmark, we verify that AA is about 4x slower than noAA in path_fill_big_rotated_rect. This is what I aim to improve in the next CL. BUG=skia: ========== to ========== Benchmark rotated rect with AA/noAA Using this benchmark, we verify that AA is about 4x slower than noAA in path_fill_big_rotated_rect. This is what I aim to improve in the next CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003 ==========
Description was changed from ========== Benchmark rotated rect with AA/noAA Using this benchmark, we verify that AA is about 4x slower than noAA in path_fill_big_rotated_rect. This is what I aim to improve in the next CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003 ========== to ========== Benchmark rotated rect with AA/noAA Using this benchmark, we verify that AA is about 4x slower than noAA in path_fill_big_rotated_rect. This is what I aim to improve in the next CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003 ==========
liyuqian@google.com changed reviewers: + reed@google.com
Hi Mike, I added a benchmark so that I can compare the old approach with the new approach that I'm going to implement in the next step. Please see if the benchmark seems reasonable to you. You can see the local benchmark result in: https://docs.google.com/a/google.com/document/d/18wpzZSxWLyrLhYmW9Q2MTkav54vI...
lgtm
The CQ bit was checked by liyuqian@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2087453003/#ps20001 (title: "Parent")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087453003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by liyuqian@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087453003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by liyuqian@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2087453003/#ps40001 (title: "Scalar")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087453003/40001
Message was sent while issue was closed.
Description was changed from ========== Benchmark rotated rect with AA/noAA Using this benchmark, we verify that AA is about 4x slower than noAA in path_fill_big_rotated_rect. This is what I aim to improve in the next CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003 ========== to ========== Benchmark rotated rect with AA/noAA Using this benchmark, we verify that AA is about 4x slower than noAA in path_fill_big_rotated_rect. This is what I aim to improve in the next CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087453003 Committed: https://skia.googlesource.com/skia/+/a27f669f460e9186dbb3ebe3e9323acef95d41b8 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/a27f669f460e9186dbb3ebe3e9323acef95d41b8 |
