Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2087433003: PPC/s390: [builtins] Introduce a proper BUILTIN frame type. (Closed)

Created:
4 years, 6 months ago by JaideepBajwa
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Introduce a proper BUILTIN frame type. Port f47b9e981035c887bda5ae66203e458eb37a5a65 Original commit message: This adds a new BUILTIN frame type, which supports variable number of arguments for builtins implemented in hand-written native code (we will extend this mechanism to TurboFan builtins at some point). Convert the Math.max and Math.min builtins to construct a BUILTIN frame if required. This does not yet work for C++ builtins, but that'll be the next step. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4815 LOG=N Committed: https://crrev.com/2b8f55456af77aa10d65b4cbd7fc7266fc521867 Cr-Commit-Position: refs/heads/master@{#37157}

Patch Set 1 #

Patch Set 2 : added fixes #

Patch Set 3 : fixed register name for ppc #

Patch Set 4 : fixed load instr #

Patch Set 5 : added fixes for ppc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -58 lines) Patch
M src/ppc/builtins-ppc.cc View 1 2 3 4 4 chunks +44 lines, -29 lines 0 comments Download
M src/s390/builtins-s390.cc View 1 3 chunks +37 lines, -29 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
JaideepBajwa
PTAL
4 years, 6 months ago (2016-06-20 19:29:41 UTC) #1
john.yan
lgtm
4 years, 6 months ago (2016-06-21 21:13:03 UTC) #2
john.yan
lgtm
4 years, 6 months ago (2016-06-21 21:15:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087433003/80001
4 years, 6 months ago (2016-06-21 21:16:03 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-21 21:41:34 UTC) #6
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/2b8f55456af77aa10d65b4cbd7fc7266fc521867 Cr-Commit-Position: refs/heads/master@{#37157}
4 years, 6 months ago (2016-06-21 21:43:44 UTC) #8
jgruber
4 years, 5 months ago (2016-07-01 07:11:25 UTC) #9
Message was sent while issue was closed.
On 2016/06/21 21:43:44, commit-bot: I haz the power wrote:
> Patchset 5 (id:??) landed as
> https://crrev.com/2b8f55456af77aa10d65b4cbd7fc7266fc521867
> Cr-Commit-Position: refs/heads/master@{#37157}

Quick heads-up: f47b9e981035c887bda5ae66203e458eb37a5a65 was incorrect on arm
and arm64, see https://codereview.chromium.org/2112883002/.

Powered by Google App Engine
This is Rietveld 408576698