Fix smoke codegen for [].

pkg/smoke/lib/codegen/generator.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Library to generate code that can initialize the `StaticConfiguration` in
 /// `package:smoke/static.dart`.
 ///
 /// This library doesn't have any specific logic to extract information from
 /// Dart source code. To extract code using the analyzer, take a look at the
 /// `smoke.codegen.recorder` library.
@@ skipping 164 matching lines @@
   /// sorted alphabetically.
   ///
   /// **Note**: this code assumes that imports from [writeImports] and top-level
   /// declarations from [writeTopLevelDeclarations] are included in the same
   /// library where this code will live.
   void writeInitCall(StringBuffer buffer, [int indent = 2]) {
     final spaces = new List.filled(indent, ' ').join('');
     var args = {};
 
     if (_getters.isNotEmpty) {
-      args['getters'] = _getters.map((n) => '#$n: (o) => o.$n');
+      args['getters'] = _getters.map((n) => '${_symbol(n)}: (o) => o.$n');
     }
     if (_setters.isNotEmpty) {
-      args['setters'] = _setters.map((n) => '#$n: (o, v) { o.$n = v; }');
+      args['setters'] = _setters.map(
+          (n) => '${_symbol(n)}: (o, v) { o.$n = v; }');
     }
 
     if (_parents.isNotEmpty) {
       var parentsMap = [];
       _parents.forEach((child, parent) {
         var parent = _parents[child];
         parentsMap.add('${child.asCode(_libraryPrefix)}: '
           '${parent.asCode(_libraryPrefix)}');
       });
       args['parents'] = parentsMap;
     }
 
     if (_declarations.isNotEmpty) {
       var declarations = [];
       _declarations.forEach((type, members) {
         final sb = new StringBuffer()
             ..write(type.asCode(_libraryPrefix))
             ..write(': ');
         if (members.isEmpty) {
           sb.write('const {}');
         } else {
           sb.write('{\n');
           members.forEach((name, decl) {
             var decl = members[name].asCode(_libraryPrefix);
-            sb.write('$spaces        #$name: $decl,\n');
+            sb.write('$spaces        ${_symbol(name)}: $decl,\n');
           });
           sb.write('$spaces      }');
         }
         declarations.add(sb.toString());
       });
       args['declarations'] = declarations;
     }
 
     if (_staticMethods.isNotEmpty) {
       var methods = [];
       _staticMethods.forEach((type, members) {
         var className = type.asCode(_libraryPrefix);
         final sb = new StringBuffer()
             ..write(className)
             ..write(': ');
         if (members.isEmpty) {
           sb.write('const {}');
         } else {
           sb.write('{\n');
           for (var name in members) {
-            sb.write('$spaces        #$name: $className.$name,\n');
+            sb.write('$spaces        ${_symbol(name)}: $className.$name,\n');
           }
           sb.write('$spaces      }');
         }
         methods.add(sb.toString());
       });
       args['staticMethods'] = methods;
     }
 
     if (_names.isNotEmpty) {
-      args['names'] = _names.map((n) => "#$n: r'$n'");
+      args['names'] = _names.map((n) => "${_symbol(n)}: r'$n'");
     }
 
     buffer..write(spaces)
         ..writeln('useGeneratedCode(new StaticConfiguration(')
         ..write('$spaces    checkedMode: false');
 
     args.forEach((name, mapContents) {
       buffer.writeln(',');
       // TODO(sigmund): use const map when Type can be keys (dartbug.com/17123)
       buffer.writeln('$spaces    $name: {');
@@ skipping 23 matching lines @@
 
   _DeclarationCode(this.name, this.type, this.kind, this.isFinal, this.isStatic,
       this.annotations);
 
   List<String> get librariesUsed => []
       ..addAll(type.librariesUsed)
       ..addAll(annotations.expand((a) => a.librariesUsed));
 
   String asCode(Map<String, String> libraryPrefixes) {
     var sb = new StringBuffer();
-    sb.write("const Declaration(#$name, ${type.asCode(libraryPrefixes)}");
+    sb.write('const Declaration(${_symbol(name)}, '
+        '${type.asCode(libraryPrefixes)}');
     if (kind != 'FIELD') sb.write(', kind: $kind');
     if (isFinal) sb.write(', isFinal: true');
     if (isStatic) sb.write(', isStatic: true');
     if (annotations != null && annotations.isNotEmpty) {
       sb.write(', annotations: const [');
       bool first = true;
       for (var e in annotations) {
         if (!first) sb.write(', ');
         first = false;
         sb.write(e.asCode(libraryPrefixes));
@@ skipping 149 matching lines @@
       comment == other.comment;
   int get hashCode => super.hashCode;
 }
 
 /// Default set of imports added by [SmokeCodeGenerator].
 const DEFAULT_IMPORTS = const [
     "import 'package:smoke/smoke.dart' show Declaration, PROPERTY, METHOD;",
     "import 'package:smoke/static.dart' show "
         "useGeneratedCode, StaticConfiguration;",
   ];
+
+_symbol(String name) =>
+   name.contains('[') ? "const Symbol('$name')" : '#$name';