Add process type to MicroDumpExtraInfo

client/linux/microdump_writer/microdump_writer.cc

 // Copyright (c) 2014, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 146 matching lines @@
     if (!dumper_->Init() || !log_line_)
       return false;
     return dumper_->ThreadsSuspend() && dumper_->LateInit();
   }
 
   bool Dump() {
     bool success;
     LogLine("-----BEGIN BREAKPAD MICRODUMP-----");
     DumpProductInformation();
     DumpOSInformation();
+    DumpProcessType();
     DumpGPUInformation();
 #if !defined(__LP64__)
     DumpFreeSpace();
 #endif
     success = DumpCrashingThread();
     if (success)
       success = DumpMappings();
     LogLine("-----END BREAKPAD MICRODUMP-----");
     dumper_->ThreadsResume();
     return success;
@@ skipping 49 matching lines @@
   void DumpProductInformation() {
     LogAppend("V ");
     if (microdump_extra_info_.product_info) {
       LogAppend(microdump_extra_info_.product_info);
     } else {
       LogAppend("UNKNOWN:0.0.0.0");
     }
     LogCommitLine();
   }
 
+  void DumpProcessType() {
+    LogAppend("P ");

[hush (inactive), 2016/06/22 20:46:01]

Hello Torne, do you know if this letter matter?
I see we've already have V, O, A, L, G, S etc. Does anything tries to parse the
string based on the first letter of each line?

[Torne, 2016/06/23 13:31:37]

Yes, the processor uses the letter to determine what data the line contains,
since they aren't otherwise self-explaining. This should be fine. I believe it
just ignores unknown lines, but you could check with Maria to be sure?

+    if (microdump_extra_info_.process_type) {
+      LogAppend(microdump_extra_info_.process_type);
+    } else {
+      LogAppend("UNKOWN");

[Torne, 2016/06/23 13:31:37]

Missing an "N" :)

+    }
+    LogCommitLine();
+  }
+
   void DumpOSInformation() {
     const uint8_t n_cpus = static_cast<uint8_t>(sysconf(_SC_NPROCESSORS_CONF));
 
 #if defined(__ANDROID__)
     const char kOSId[] = "A";
 #else
     const char kOSId[] = "L";
 #endif
 
 // Dump the runtime architecture. On multiarch devices it might not match the
@@ skipping 343 matching lines @@
     dumper.set_crash_signal(context->siginfo.si_signo);
     dumper.set_crash_thread(context->tid);
   }
   MicrodumpWriter writer(context, mappings, microdump_extra_info, &dumper);
   if (!writer.Init())
     return false;
   return writer.Dump();
 }
 
 }  // namespace google_breakpad