Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2087403002: GN: just new deps (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 6 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org, bsalomon
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: just new deps These just are the DEPS changes from the previous GN CL, each rolled up to head. I've removed the hooks to fetch GN and Clang... will have to figure out how to deal with .gclient files in different places later. BUG=skia:5452 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2087403002 Committed: https://skia.googlesource.com/skia/+/e4a712b66571f80cf0f717ff51e3011a068363a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M .gitignore View 1 chunk +4 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
Surely just starting with some new DEPS is foolproof, right?
4 years, 6 months ago (2016-06-22 20:12:22 UTC) #3
rmistry
On 2016/06/22 20:12:22, mtklein_C wrote: > Surely just starting with some new DEPS is foolproof, ...
4 years, 6 months ago (2016-06-23 11:10:58 UTC) #4
borenet
LGTM
4 years, 6 months ago (2016-06-23 11:31:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087403002/1
4 years, 6 months ago (2016-06-23 12:42:24 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 12:56:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e4a712b66571f80cf0f717ff51e3011a068363a0

Powered by Google App Engine
This is Rietveld 408576698