Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Issue 2087383002: Fix destruction order between SurfaceManger and OffscreenCanvasSurfaceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_surface_impl.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
index edbed1acad500d6efd8bbfec98f50754cfea202f..1988292d7d0e700acf814d0da38f7b96bc6f7c00 100644
--- a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
+++ b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc
@@ -9,6 +9,7 @@
#include "cc/surfaces/surface_manager.h"
#include "content/browser/compositor/surface_utils.h"
#include "content/public/browser/browser_thread.h"
+#include <iostream>
namespace content {
@@ -25,6 +26,12 @@ OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl(
binding_(this, std::move(request)) {}
OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() {
+ if (!GetSurfaceManager()) {
Justin Novosad 2016/06/22 20:47:09 Is is not possible to call GetSurfaceManager in Su
xlai (Olivia) 2016/06/23 14:49:38 Cannot...cc/ folder cannot import things from cont
+ std::cout << "surface manager no longer exists! " << std::endl;
+ surface_factory_->onSurfaceManagerDestroyed();
+ }
+ surface_factory_.reset();
+ //surface_factory_->DestroyAll();
}
void OffscreenCanvasSurfaceImpl::GetSurfaceId(
« cc/surfaces/surface_factory.cc ('K') | « content/browser/compositor/surface_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698