Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2087373004: Remove unused ASH files from GN build script (Closed)

Created:
4 years, 6 months ago by zoli
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= Committed: https://crrev.com/2839c842a5ff78c5b6ba1009dcecb39bef924a39 Cr-Commit-Position: refs/heads/master@{#403306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 31 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087373004/1
4 years, 6 months ago (2016-06-23 14:57:13 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 6 months ago (2016-06-23 14:57:15 UTC) #4
zoli
Hi, could you review my change? Thanks, Zoltan
4 years, 6 months ago (2016-06-23 15:05:43 UTC) #9
Ken Rockot(use gerrit already)
lgtm
4 years, 6 months ago (2016-06-23 15:06:52 UTC) #10
Ken Rockot(use gerrit already)
On 2016/06/23 at 15:06:52, Ken Rockot wrote: > lgtm (but of course I'm not an ...
4 years, 6 months ago (2016-06-23 15:07:16 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087373004/1
4 years, 6 months ago (2016-06-24 09:19:49 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-24 10:17:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2087373004/1
4 years, 5 months ago (2016-06-30 17:20:22 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/210589)
4 years, 5 months ago (2016-06-30 17:29:48 UTC) #19
zoli
Added reviewers.
4 years, 5 months ago (2016-06-30 18:32:40 UTC) #21
sky
LGTM
4 years, 5 months ago (2016-06-30 21:11:30 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2087373004/1
4 years, 5 months ago (2016-06-30 21:55:42 UTC) #26
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 22:03:22 UTC) #28
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 22:03:31 UTC) #29
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 22:05:23 UTC) #31
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2839c842a5ff78c5b6ba1009dcecb39bef924a39
Cr-Commit-Position: refs/heads/master@{#403306}

Powered by Google App Engine
This is Rietveld 408576698