|
|
DescriptionRemove unused ASH files from GN build script
chrome_browser_ui_ash_non_chromeos was
already removed from .gypi files by an earlier patch.
BUG=
Committed: https://crrev.com/2839c842a5ff78c5b6ba1009dcecb39bef924a39
Cr-Commit-Position: refs/heads/master@{#403306}
Patch Set 1 #
Messages
Total messages: 31 (16 generated)
The CQ bit was checked by zoltan.kuscsik@linaro.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087373004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was were removed from .gypi files by an earlier patch. BUG= ========== to ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= ==========
Description was changed from ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= ========== to ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= R=rockot, brettw ==========
Description was changed from ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= R=rockot, brettw ========== to ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= ==========
zoltan.kuscsik@linaro.org changed reviewers: + brettw@chromium.org, rockot@chromium.org
Hi, could you review my change? Thanks, Zoltan
lgtm
On 2016/06/23 at 15:06:52, Ken Rockot wrote: > lgtm (but of course I'm not an owner in any relevant areas here)
The CQ bit was checked by zoltan.kuscsik@linaro.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2087373004/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by zoltan.kuscsik@linaro.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
zoltan.kuscsik@linaro.org changed reviewers: + pkasting@google.com, sky@chromium.org
Added reviewers.
The CQ bit was checked by zoltan.kuscsik@linaro.org
The CQ bit was unchecked by zoltan.kuscsik@linaro.org
LGTM
The CQ bit was checked by zoltan.kuscsik@linaro.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= ========== to ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= ========== to ========== Remove unused ASH files from GN build script chrome_browser_ui_ash_non_chromeos was already removed from .gypi files by an earlier patch. BUG= Committed: https://crrev.com/2839c842a5ff78c5b6ba1009dcecb39bef924a39 Cr-Commit-Position: refs/heads/master@{#403306} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2839c842a5ff78c5b6ba1009dcecb39bef924a39 Cr-Commit-Position: refs/heads/master@{#403306} |